staticaddr: replace block-based deposit detection with polling

Block-based deposit fetching from the internal lnd wallet was
susceptible to wallet syncing issues. Replace it with interval-based
polling. Reconciliation errors are now logged instead of being fatal,
improving resilience during transient failures.

Author: hieblmi

staticaddr/deposit/manager.go

@@ -32,6 +32,10 @@ const (
 	// DefaultTransitionTimeout is the default timeout for transitions in
 	// the deposit state machine.
 	DefaultTransitionTimeout = 5 * time.Second
+
+	// PollInterval is the interval in which we poll for new deposits to our
+	// static address.
+	PollInterval = 10 * time.Second
 )
 
 // ManagerConfig holds the configuration for the address manager.
@@ -116,14 +120,16 @@ func (m *Manager) Run(ctx context.Context, initChan chan struct{}) error {
 		return err
 	}
 
-	// Initially reconcile new deposits after a restart, so we catch up with
-	// missed deposits while we were offline.
-	if err = m.reconcileDeposits(ctx); err != nil {
+	// Reconcile immediately on startup so deposits are available
+	// before the first ticker fires.
+	err = m.reconcileDeposits(ctx)
+	if err != nil {
 		log.Errorf("unable to reconcile deposits: %v", err)
-
-		return err
 	}
 
+	// Start the deposit notifier.
+	m.pollDeposits(ctx)
+
 	// Communicate to the caller that the address manager has completed its
 	// initialization.
 	close(initChan)
@@ -151,15 +157,6 @@ func (m *Manager) Run(ctx context.Context, initChan chan struct{}) error {
 				}
 			}
 
-			// Reconcile new deposits that might have just gotten
-			// confirmed.
-			if err = m.reconcileDeposits(ctx); err != nil {
-				log.Errorf("unable to reconcile deposits: %v",
-					err)
-
-				return err
-			}
-
 		case outpoint := <-m.finalizedDepositChan:
 			// If deposits notify us about their finalization, flush
 			// the finalized deposit from memory.
@@ -224,6 +221,30 @@ func (m *Manager) recoverDeposits(ctx context.Context) error {
 	return nil
 }
 
+// pollDeposits polls new deposits to our static address and notifies the
+// manager's event loop about them.
+func (m *Manager) pollDeposits(ctx context.Context) {
+	log.Debugf("Waiting for new static address deposits...")
+
+	go func() {
+		ticker := time.NewTicker(PollInterval)
+		defer ticker.Stop()
+		for {
+			select {
+			case <-ticker.C:
+				err := m.reconcileDeposits(ctx)
+				if err != nil {
+					log.Errorf("unable to reconcile "+
+						"deposits: %v", err)
+				}
+
+			case <-ctx.Done():
+				return
+			}
+		}
+	}()
+}
+
 // reconcileDeposits fetches all spends to our static addresses from our lnd
 // wallet and matches it against the deposits in our memory that we've seen so
 // far. It picks the newly identified deposits and starts a state machine per