cmd/loop: drop misleading static loop-in fee warning

Author: hieblmi

cmd/loop/main.go

@@ -329,12 +329,6 @@ func displayInDetails(req *looprpc.QuoteRequest,
 			"wallet.\n\n")
 	}
 
-	if req.DepositOutpoints != nil {
-		fmt.Printf("On-chain fees for static address loop-ins are not " +
-			"included.\nThey were already paid when the deposits " +
-			"were created.\n\n")
-	}
-
 	printQuoteInResp(req, resp, verbose)
 
 	fmt.Printf("\nCONTINUE SWAP? (y/n): ")

cmd/loop/main_test.go

@@ -0,0 +1,73 @@
+package main
+
+import (
+	"io"
+	"os"
+	"testing"
+
+	"github.com/lightninglabs/loop/looprpc"
+	"github.com/stretchr/testify/require"
+)
+
+func captureDisplayInDetailsOutput(t *testing.T, req *looprpc.QuoteRequest,
+	resp *looprpc.InQuoteResponse, verbose bool) string {
+
+	t.Helper()
+
+	oldStdin := os.Stdin
+	oldStdout := os.Stdout
+
+	inReader, inWriter, err := os.Pipe()
+	require.NoError(t, err)
+
+	outReader, outWriter, err := os.Pipe()
+	require.NoError(t, err)
+
+	os.Stdin = inReader
+	os.Stdout = outWriter
+
+	t.Cleanup(func() {
+		os.Stdin = oldStdin
+		os.Stdout = oldStdout
+	})
+	t.Cleanup(func() {
+		_ = inReader.Close()
+		_ = outReader.Close()
+	})
+
+	_, err = inWriter.Write([]byte("y\n"))
+	require.NoError(t, err)
+	require.NoError(t, inWriter.Close())
+
+	err = displayInDetails(req, resp, verbose)
+	require.NoError(t, err)
+
+	require.NoError(t, outWriter.Close())
+
+	output, err := io.ReadAll(outReader)
+	require.NoError(t, err)
+
+	return string(output)
+}
+
+func TestDisplayInDetailsStaticLoopIn(t *testing.T) {
+	req := &looprpc.QuoteRequest{
+		Amt:              250_000,
+		DepositOutpoints: []string{"test-outpoint"},
+	}
+	resp := &looprpc.InQuoteResponse{
+		HtlcPublishFeeSat: 86,
+		SwapFeeSat:        300,
+	}
+
+	output := captureDisplayInDetailsOutput(t, req, resp, false)
+
+	require.NotContains(t, output,
+		"On-chain fees for static address loop-ins are not included.")
+	require.NotContains(t, output,
+		"They were already paid when the deposits were created.")
+	require.Contains(t, output,
+		"Previously deposited on-chain:             250000 sat")
+	require.Contains(t, output,
+		"Estimated total fee:                          386 sat")
+}

regtest/README.md

@@ -227,9 +227,6 @@ Let's list the deposits in the loop client:
 These deposits can now be instantly swapped. Let's use the first one:
 ```shell
 ./regtest.sh loop static in --utxo 5405e5cae38f9e4e193f7b5442dd005273e2e1fab8687c42a505c1a333e8884f:0
-On-chain fees for static address loop-ins are not included.
-They were already paid when the deposits were created.
-
 Previously deposited on-chain:             250000 sat
 Receive off-chain:                         249614 sat
 Estimated total fee:                          386 sat
@@ -266,9 +263,6 @@ We can combine the remaining two deposits in another instant swap by specifying
 the `--all` flag:
 ```shell
 ./regtest.sh loop static in --all                                                                     ✔  12:07:28 
-On-chain fees for static address loop-ins are not included.
-They were already paid when the deposits were created.
-
 Previously deposited on-chain:             500000 sat
 Receive off-chain:                         499302 sat
 Estimated total fee:                          698 sat