staticaddr/withdraw: add retry and reorg handling for withdrawals

This commit fixes three related issues in the withdrawal manager:

1. No retry when RegisterSpendNtfn/RegisterConfirmationsNtfn fails
2. No handling for reorgs (tx confirmed then reorged out)
3. State not persisted before handleWithdrawal, causing recovery failures

Changes:
- Reorder state persistence to happen BEFORE handleWithdrawal so
  recoverWithdrawals can find deposits in Withdrawing state on restart
- Add retry-on-next-block for registration failures using block
  notifications
- Add reorg detection via lndclient.WithReOrgChan for both spend and
  confirmation notifications
- On reorg after spend detection, return to spend watching (not just
  re-register for confirmations) since the spend tx may be invalidated
- Make handleWithdrawal async/best-effort since tx is already published
- Added appropriate tests in manager_test.go

Fixes issue #1087

Signed-off-by: kaldun-tech <tsmereka@protonmail.com>

Author: kaldun-tech

release_notes.md

@@ -20,4 +20,13 @@ This file tracks release notes for the loop client.
 
 #### Bug Fixes
 
+* [Static Address Withdrawals: Add retry and reorg handling for withdrawal
+  confirmations](https://github.com/lightninglabs/loop/issues/1087).
+  Previously, if `RegisterSpendNtfn` or `RegisterConfirmationsNtfn` failed,
+  the withdrawal monitoring would silently stop. Additionally, reorgs were not
+  handled, and state was not persisted before monitoring setup, causing
+  recovery failures on restart. This fix adds automatic retry on next block
+  for registration failures, proper reorg detection via `WithReOrgChan`, and
+  reorders state persistence to occur before monitoring setup.
+
 #### Maintenance