Remove RBF coop close staging feature bits#10891
Conversation
Now that the final RBF-based co-op close feature bits (rbf-coop-close, bits 60/61) have been in production for a while, the staging feature bits (rbf-coop-close-x, bits 160/161) are no longer needed.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request cleans up the codebase by removing deprecated staging feature bits associated with the RBF-based co-op close protocol. Since the final production feature bits have been successfully deployed for a sufficient period, the staging bits are no longer required for signaling or negotiation, allowing for a simplified feature set and reduced technical debt. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request removes the staging feature bits for the RBF-based co-op close protocol (rbf-coop-close-x, bits 160/161) from the codebase, including the feature manager, default sets, wire definitions, and peer connection logic. A review comment suggests adding nil checks for RemoteFeatures() and LocalFeatures() in rbfCoopCloseAllowed() to prevent potential nil pointer dereference panics.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
PR Severity: CRITICAL | Automated classification | 5 files | 31 lines changed CRITICAL files: lnwire/features.go (wire protocol messages), peer/brontide.go (peer connections/Noise protocol) Analysis: lnwire/features.go and peer/brontide.go are CRITICAL packages. Feature bit changes affect protocol negotiation across all Lightning nodes. PR removes feature bits (net -13 lines) suggesting experimental feature deprecation. Expert review required for backward compatibility with peers still advertising removed features. To override: add severity-override-{critical,high,medium,low} label. |
|
@MPins, remember to re-request review from reviewers when ready |
Fixes #9892
Now that the final RBF-based co-op close feature bits (rbf-coop-close, bits 60/61) have been in production for a while, the staging feature bits (rbf-coop-close-x, bits 160/161) are no longer needed.