Skip to content

Commit 3a6f73b

Browse files
committed
try to improve test ws shutdown, merge ws tests
1 parent 59df3bd commit 3a6f73b

6 files changed

Lines changed: 4 additions & 327 deletions

File tree

src/TestWSServer.zig

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -31,18 +31,13 @@ pub fn init() TestWSServer {
3131
};
3232
}
3333

34-
pub fn deinit(self: *TestWSServer) void {
35-
if (self.listener) |socket| {
36-
posix.close(socket);
37-
self.listener = null;
38-
}
39-
}
40-
4134
pub fn stop(self: *TestWSServer) void {
4235
self.shutdown.store(true, .release);
4336
if (self.listener) |socket| {
44-
posix.close(socket);
45-
self.listener = null;
37+
switch (@import("builtin").target.os.tag) {
38+
.linux => std.posix.shutdown(socket, .recv) catch {},
39+
else => std.posix.close(socket),
40+
}
4641
}
4742
}
4843

src/browser/tests/net/websocket.html

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -309,7 +309,6 @@
309309
const state = await testing.async();
310310
let received = [];
311311

312-
console.warn('last-test');
313312
let ws = new WebSocket('ws://127.0.0.1:9584/');
314313
ws.binaryType = 'arraybuffer';
315314

@@ -328,7 +327,6 @@
328327
});
329328

330329
await state.done(() => {
331-
console.warn('aaa');
332330
// 1 marker byte + 8 bytes (2 x 4-byte int32)
333331
testing.expectEqual([9], received);
334332
});

src/browser/tests/net/websocket2.html

Lines changed: 0 additions & 233 deletions
This file was deleted.

src/browser/tests/net/websocket3.html

Lines changed: 0 additions & 77 deletions
This file was deleted.

src/browser/webapi/net/WebSocket.zig

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -693,8 +693,5 @@ pub const JsApi = struct {
693693

694694
const testing = @import("../../../testing.zig");
695695
test "WebApi: WebSocket" {
696-
// TEMP since we're currently limited to 10 concurrent connections
697696
try testing.htmlRunner("net/websocket.html", .{});
698-
try testing.htmlRunner("net/websocket2.html", .{});
699-
try testing.htmlRunner("net/websocket3.html", .{});
700697
}

src/testing.zig

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -556,9 +556,6 @@ test "tests:afterAll" {
556556
if (test_ws_server_thread) |thread| {
557557
thread.join();
558558
}
559-
if (test_ws_server) |*server| {
560-
server.deinit();
561-
}
562559

563560
@import("root").v8_peak_memory = test_browser.env.isolate.getHeapStatistics().total_physical_size;
564561

0 commit comments

Comments
 (0)