Skip to content

Commit 666ff0b

Browse files
committed
Remove unused intercept_response ParkedBy
Add comment about how unpark is meant (and not meant) to be used.
1 parent 1cdd2bb commit 666ff0b

1 file changed

Lines changed: 5 additions & 7 deletions

File tree

src/browser/HttpClient.zig

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1241,10 +1241,6 @@ pub const Transfer = struct {
12411241
// CDP Fetch interception, request phase.
12421242
intercept_request,
12431243

1244-
// CDP Fetch interception, response phase. Reserved for when
1245-
// response interception lands; not currently emitted.
1246-
intercept_response,
1247-
12481244
// CDP auth challenge — processOneMessage stashed the transfer
12491245
// waiting for continueWithAuth.
12501246
intercept_auth,
@@ -1261,9 +1257,11 @@ pub const Transfer = struct {
12611257
}
12621258

12631259
// Layer-facing: take the transfer out of .parked and return it to
1264-
// the request flow (.created). Caller is expected to re-enter the
1265-
// layer chain or call abort(); if neither happens the transfer is
1266-
// stranded.
1260+
// the request flow (.created). This assumes pre-inflight handling (i.e. the
1261+
// transfer was in .created before being parked). This is true today, but
1262+
// could become false if Request Interception ever supports the "response"
1263+
// requestStage (although, to support this, I think the safety of transfers
1264+
// post-perform would need to be improved),
12671265
pub fn unpark(self: *Transfer) void {
12681266
lp.assert(self.state == .parked, "Transfer.unpark", .{ .state = self.state });
12691267
self.state = .created;

0 commit comments

Comments
 (0)