Skip to content

Commit 8eeeeda

Browse files
authored
Merge pull request #2021 from evan108108/fix/navigator-spec-compliance
fix: navigator.languages should include base language per spec
2 parents 75dc4d5 + 273ea91 commit 8eeeeda

2 files changed

Lines changed: 4 additions & 3 deletions

File tree

src/browser/tests/navigator/navigator.html

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,9 @@
1515
testing.expectEqual(true, validPlatforms.includes(navigator.platform));
1616
testing.expectEqual('en-US', navigator.language);
1717
testing.expectEqual(true, Array.isArray(navigator.languages));
18-
testing.expectEqual(1, navigator.languages.length);
18+
testing.expectEqual(2, navigator.languages.length);
1919
testing.expectEqual('en-US', navigator.languages[0]);
20+
testing.expectEqual('en', navigator.languages[1]);
2021
testing.expectEqual(true, navigator.onLine);
2122
testing.expectEqual(true, navigator.cookieEnabled);
2223
testing.expectEqual(true, navigator.hardwareConcurrency > 0);

src/browser/webapi/Navigator.zig

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,8 @@ pub fn getUserAgent(_: *const Navigator, page: *Page) []const u8 {
4040
return page._session.browser.app.config.http_headers.user_agent;
4141
}
4242

43-
pub fn getLanguages(_: *const Navigator) [1][]const u8 {
44-
return .{"en-US"};
43+
pub fn getLanguages(_: *const Navigator) [2][]const u8 {
44+
return .{ "en-US", "en" };
4545
}
4646

4747
pub fn getPlatform(_: *const Navigator) []const u8 {

0 commit comments

Comments
 (0)