prefer dash for binary options (#14)

* prefer dash for binary options

* chore: upgrade node 22

* fix: typecheck

---------

Co-authored-by: Nicolas Rigaudiere <i.am.a@curious.engineer>

Author: krichprollsch

packages/browser/package.json

@@ -35,6 +35,10 @@
     "url": "https://github.com/lightpanda-io/node-packages/issues"
   },
   "homepage": "https://github.com/lightpanda-io/node-packages/tree/main/packages/browser#readme",
+  "engines": {
+    "node": "22.16",
+    "yarn": "4.9"
+  },
   "devDependencies": {
     "@biomejs/biome": "^1.9.4",
     "@types/node": "22.15.32",
@@ -46,4 +50,4 @@
   "dependencies": {
     "yargs": "^18.0.0"
   }
-}
+}

packages/browser/src/download.ts

@@ -39,13 +39,19 @@ const PLATFORMS = {
     arm64: 'aarch64-linux',
   },
 }
+const CURRENT_PLATFORM = platform as 'darwin' | 'linux'
+const CURRENT_ARCH = arch as 'arm64' | 'x64'
 
 /**
  * Download Lightpanda's binary
  * @returns {Promise<void>}
  */
 export const download = async (): Promise<void> => {
-  const platformPath = PLATFORMS?.[platform]?.[arch]
+  if (!['linux', 'darwin'].includes(platform)) {
+    throw new Error('Architecture or platform is not compatible with Lightpanda')
+  }
+
+  const platformPath = PLATFORMS?.[CURRENT_PLATFORM]?.[CURRENT_ARCH]
 
   if (!existsSync(DEFAULT_CACHE_FOLDER)) {
     mkdirSync(DEFAULT_CACHE_FOLDER, { recursive: true })
@@ -91,7 +97,7 @@ export const download = async (): Promise<void> => {
       }
 
       return ''
-    } catch (e) {
+    } catch (e: any) {
       throw new Error(e)
     }
   }

packages/browser/src/fetch.ts

@@ -58,9 +58,9 @@ export const fetch = (url: string, options: LightpandaFetchOptions = defaultOpti
       const executablePath = getExecutablePath()
       const flags = [
         { flag: `--dump ${dumpOptions?.type ?? 'html'}`, condition: dump },
-        { flag: '--insecure_disable_tls_host_verification', condition: disableHostVerification },
-        { flag: '--obey_robots', condition: obeyRobots },
-        { flag: `--http_proxy ${httpProxy}`, condition: httpProxy },
+        { flag: '--insecure-disable-tls-host-verification', condition: disableHostVerification },
+        { flag: '--obey-robots', condition: obeyRobots },
+        { flag: `--http-proxy ${httpProxy}`, condition: httpProxy },
       ]
         .map(f => (f.condition ? f.flag : ''))
         .join(' ')

packages/browser/src/serve.ts

@@ -62,16 +62,16 @@ export const serve = (options: LightpandaServeOptions = defaultOptions) => {
       { flag: '--port', value: port },
       { flag: '--timeout', value: timeout },
       {
-        flag: '--insecure_disable_tls_host_verification',
+        flag: '--insecure-disable-tls-host-verification',
         value: disableHostVerification,
         flagOnly: true,
       },
       {
-        flag: '--obey_robots',
+        flag: '--obey-robots',
         value: obeyRobots,
         flagOnly: true,
       },
-      { flag: '--http_proxy', value: httpProxy },
+      { flag: '--http-proxy', value: httpProxy },
     ]
       .flatMap(f => (f.value ? [f.flag, !f.flagOnly ? f.value.toString() : ''] : ''))
       .filter(f => f !== '')

packages/browser/tsconfig.json

@@ -1,12 +1,16 @@
 {
   "compilerOptions": {
-    "module": "esnext",
+    "module": "nodenext",
+    "moduleResolution": "nodenext",
+    "types": ["node"],
     "esModuleInterop": true,
     "target": "es6",
-    "moduleResolution": "node",
     "resolveJsonModule": true,
     "sourceMap": true,
     "outDir": "dist",
+    "declaration": true,
+    "composite": true,
+    "declarationMap": true,
     "paths": {
       "lightpanda/*": ["./src/*"],
       "scripts/*": ["./scripts/*"]