Fix cargo clippy errors (#6)

janjakubnanista · Copilot · web-flow · commit 3b4431fee8b2 · 2026-05-08T10:27:21.000-07:00
Fix linting errors detected by `cargo clippy`, e.g. [here](https://github.com/lightsparkdev/frost/actions/runs/25526826564/job/74924248860) Co-authored-by: Copilot <copilot@github.com>
diff --git a/frost-core/src/lib.rs b/frost-core/src/lib.rs
@@ -415,7 +415,7 @@ where
         SigningPackage {
             header: Header::default(),
             signing_commitments,
-            signing_participants_groups: signing_participants_groups,
+            signing_participants_groups,
             message: message.to_vec(),
             adaptor: None,
         }
@@ -431,9 +431,9 @@ where
         SigningPackage {
             header: Header::default(),
             signing_commitments,
-            signing_participants_groups: signing_participants_groups,
+            signing_participants_groups,
             message: message.to_vec(),
-            adaptor: adaptor,
+            adaptor,
         }
     }
 
diff --git a/frost-core/src/round2.rs b/frost-core/src/round2.rs
@@ -164,7 +164,7 @@ pub fn sign<C: Ciphersuite>(
         Some(signing_participants_groups) => {
             let mut result: Result<Scalar<C>, Error<C>> = Err(Error::UnknownIdentifier);
             for signing_participants_group in signing_participants_groups {
-                if signing_participants_group.contains(&key_package.identifier()) {
+                if signing_participants_group.contains(key_package.identifier()) {
                     result = frost::compute_lagrange_coefficient(
                         &signing_participants_group,
                         None,
diff --git a/frost-ed25519/tests/common_traits_tests.rs b/frost-ed25519/tests/common_traits_tests.rs
@@ -9,7 +9,7 @@ use helpers::samples;
 fn check_common_traits_for_type<T: Clone + Eq + PartialEq + std::fmt::Debug>(v: T) {
     // Make sure can be debug-printed. This also catches if the Debug does not
     // have an endless recursion (a popular mistake).
-    println!("{:?}", v);
+    println!("{v:?}");
     // Test Clone and Eq
     assert_eq!(v, v.clone());
     // Make sure it can be unwrapped in a Result (which requires Debug).
diff --git a/frost-ed25519/tests/serde_tests.rs b/frost-ed25519/tests/serde_tests.rs
@@ -19,7 +19,7 @@ fn check_signing_commitments_serialization() {
     let commitments = samples::signing_commitments();
 
     let json = serde_json::to_string_pretty(&commitments).unwrap();
-    println!("{}", json);
+    println!("{json}");
 
     let decoded_commitments: SigningCommitments = serde_json::from_str(&json).unwrap();
     assert!(commitments == decoded_commitments);
@@ -89,7 +89,7 @@ fn check_signing_package_serialization() {
     let signing_package = samples::signing_package();
 
     let json = serde_json::to_string_pretty(&signing_package).unwrap();
-    println!("{}", json);
+    println!("{json}");
 
     let decoded_signing_package: SigningPackage = serde_json::from_str(&json).unwrap();
     assert!(signing_package == decoded_signing_package);
@@ -204,7 +204,7 @@ fn check_signature_share_serialization() {
     let signature_share = samples::signature_share();
 
     let json = serde_json::to_string_pretty(&signature_share).unwrap();
-    println!("{}", json);
+    println!("{json}");
 
     let decoded_signature_share: SignatureShare = serde_json::from_str(&json).unwrap();
     assert!(signature_share == decoded_signature_share);
@@ -258,7 +258,7 @@ fn check_secret_share_serialization() {
     let secret_share = samples::secret_share();
 
     let json = serde_json::to_string_pretty(&secret_share).unwrap();
-    println!("{}", json);
+    println!("{json}");
 
     let decoded_secret_share: SecretShare = serde_json::from_str(&json).unwrap();
     assert!(secret_share == decoded_secret_share);
@@ -342,7 +342,7 @@ fn check_key_package_serialization() {
     let key_package = samples::key_package();
 
     let json = serde_json::to_string_pretty(&key_package).unwrap();
-    println!("{}", json);
+    println!("{json}");
 
     let decoded_key_package: KeyPackage = serde_json::from_str(&json).unwrap();
     assert!(key_package == decoded_key_package);
@@ -437,7 +437,7 @@ fn check_public_key_package_serialization() {
     let public_key_package = samples::public_key_package_new();
 
     let json = serde_json::to_string_pretty(&public_key_package).unwrap();
-    println!("{}", json);
+    println!("{json}");
 
     let decoded_public_key_package: PublicKeyPackage = serde_json::from_str(&json).unwrap();
     assert!(public_key_package == decoded_public_key_package);
@@ -532,7 +532,7 @@ fn check_round1_package_serialization() {
     let round1_package = samples::round1_package();
 
     let json = serde_json::to_string_pretty(&round1_package).unwrap();
-    println!("{}", json);
+    println!("{json}");
 
     let decoded_round1_package: round1::Package = serde_json::from_str(&json).unwrap();
     assert!(round1_package == decoded_round1_package);
@@ -598,7 +598,7 @@ fn check_round2_package_serialization() {
     let round2_package = samples::round2_package();
 
     let json = serde_json::to_string_pretty(&round2_package).unwrap();
-    println!("{}", json);
+    println!("{json}");
 
     let decoded_round2_package: round2::Package = serde_json::from_str(&json).unwrap();
     assert!(round2_package == decoded_round2_package);
diff --git a/frost-ed448/tests/common_traits_tests.rs b/frost-ed448/tests/common_traits_tests.rs
@@ -9,7 +9,7 @@ use helpers::samples;
 fn check_common_traits_for_type<T: Clone + Eq + PartialEq + std::fmt::Debug>(v: T) {
     // Make sure can be debug-printed. This also catches if the Debug does not
     // have an endless recursion (a popular mistake).
-    println!("{:?}", v);
+    println!("{v:?}");
     // Test Clone and Eq
     assert_eq!(v, v.clone());
     // Make sure it can be unwrapped in a Result (which requires Debug).
diff --git a/frost-ed448/tests/serde_tests.rs b/frost-ed448/tests/serde_tests.rs
@@ -19,7 +19,7 @@ fn check_signing_commitments_serialization() {
     let commitments = samples::signing_commitments();
 
     let json = serde_json::to_string_pretty(&commitments).unwrap();
-    println!("{}", json);
+    println!("{json}");
 
     let decoded_commitments: SigningCommitments = serde_json::from_str(&json).unwrap();
     assert!(commitments == decoded_commitments);
@@ -89,7 +89,7 @@ fn check_signing_package_serialization() {
     let signing_package = samples::signing_package();
 
     let json = serde_json::to_string_pretty(&signing_package).unwrap();
-    println!("{}", json);
+    println!("{json}");
 
     let decoded_signing_package: SigningPackage = serde_json::from_str(&json).unwrap();
     assert!(signing_package == decoded_signing_package);
@@ -204,7 +204,7 @@ fn check_signature_share_serialization() {
     let signature_share = samples::signature_share();
 
     let json = serde_json::to_string_pretty(&signature_share).unwrap();
-    println!("{}", json);
+    println!("{json}");
 
     let decoded_signature_share: SignatureShare = serde_json::from_str(&json).unwrap();
     assert!(signature_share == decoded_signature_share);
@@ -258,7 +258,7 @@ fn check_secret_share_serialization() {
     let secret_share = samples::secret_share();
 
     let json = serde_json::to_string_pretty(&secret_share).unwrap();
-    println!("{}", json);
+    println!("{json}");
 
     let decoded_secret_share: SecretShare = serde_json::from_str(&json).unwrap();
     assert!(secret_share == decoded_secret_share);
@@ -342,7 +342,7 @@ fn check_key_package_serialization() {
     let key_package = samples::key_package();
 
     let json = serde_json::to_string_pretty(&key_package).unwrap();
-    println!("{}", json);
+    println!("{json}");
 
     let decoded_key_package: KeyPackage = serde_json::from_str(&json).unwrap();
     assert!(key_package == decoded_key_package);
@@ -437,7 +437,7 @@ fn check_public_key_package_serialization() {
     let public_key_package = samples::public_key_package_new();
 
     let json = serde_json::to_string_pretty(&public_key_package).unwrap();
-    println!("{}", json);
+    println!("{json}");
 
     let decoded_public_key_package: PublicKeyPackage = serde_json::from_str(&json).unwrap();
     assert!(public_key_package == decoded_public_key_package);
@@ -532,7 +532,7 @@ fn check_round1_package_serialization() {
     let round1_package = samples::round1_package();
 
     let json = serde_json::to_string_pretty(&round1_package).unwrap();
-    println!("{}", json);
+    println!("{json}");
 
     let decoded_round1_package: round1::Package = serde_json::from_str(&json).unwrap();
     assert!(round1_package == decoded_round1_package);
@@ -598,7 +598,7 @@ fn check_round2_package_serialization() {
     let round2_package = samples::round2_package();
 
     let json = serde_json::to_string_pretty(&round2_package).unwrap();
-    println!("{}", json);
+    println!("{json}");
 
     let decoded_round2_package: round2::Package = serde_json::from_str(&json).unwrap();
     assert!(round2_package == decoded_round2_package);
diff --git a/frost-p256/tests/common_traits_tests.rs b/frost-p256/tests/common_traits_tests.rs
@@ -9,7 +9,7 @@ use helpers::samples;
 fn check_common_traits_for_type<T: Clone + Eq + PartialEq + std::fmt::Debug>(v: T) {
     // Make sure can be debug-printed. This also catches if the Debug does not
     // have an endless recursion (a popular mistake).
-    println!("{:?}", v);
+    println!("{v:?}");
     // Test Clone and Eq
     assert_eq!(v, v.clone());
     // Make sure it can be unwrapped in a Result (which requires Debug).
diff --git a/frost-p256/tests/serde_tests.rs b/frost-p256/tests/serde_tests.rs
@@ -19,7 +19,7 @@ fn check_signing_commitments_serialization() {
     let commitments = samples::signing_commitments();
 
     let json = serde_json::to_string_pretty(&commitments).unwrap();
-    println!("{}", json);
+    println!("{json}");
 
     let decoded_commitments: SigningCommitments = serde_json::from_str(&json).unwrap();
     assert!(commitments == decoded_commitments);
@@ -89,7 +89,7 @@ fn check_signing_package_serialization() {
     let signing_package = samples::signing_package();
 
     let json = serde_json::to_string_pretty(&signing_package).unwrap();
-    println!("{}", json);
+    println!("{json}");
 
     let decoded_signing_package: SigningPackage = serde_json::from_str(&json).unwrap();
     assert!(signing_package == decoded_signing_package);
@@ -204,7 +204,7 @@ fn check_signature_share_serialization() {
     let signature_share = samples::signature_share();
 
     let json = serde_json::to_string_pretty(&signature_share).unwrap();
-    println!("{}", json);
+    println!("{json}");
 
     let decoded_signature_share: SignatureShare = serde_json::from_str(&json).unwrap();
     assert!(signature_share == decoded_signature_share);
@@ -258,7 +258,7 @@ fn check_secret_share_serialization() {
     let secret_share = samples::secret_share();
 
     let json = serde_json::to_string_pretty(&secret_share).unwrap();
-    println!("{}", json);
+    println!("{json}");
 
     let decoded_secret_share: SecretShare = serde_json::from_str(&json).unwrap();
     assert!(secret_share == decoded_secret_share);
@@ -342,7 +342,7 @@ fn check_key_package_serialization() {
     let key_package = samples::key_package();
 
     let json = serde_json::to_string_pretty(&key_package).unwrap();
-    println!("{}", json);
+    println!("{json}");
 
     let decoded_key_package: KeyPackage = serde_json::from_str(&json).unwrap();
     assert!(key_package == decoded_key_package);
@@ -437,7 +437,7 @@ fn check_public_key_package_serialization() {
     let public_key_package = samples::public_key_package_new();
 
     let json = serde_json::to_string_pretty(&public_key_package).unwrap();
-    println!("{}", json);
+    println!("{json}");
 
     let decoded_public_key_package: PublicKeyPackage = serde_json::from_str(&json).unwrap();
     assert!(public_key_package == decoded_public_key_package);
@@ -532,7 +532,7 @@ fn check_round1_package_serialization() {
     let round1_package = samples::round1_package();
 
     let json = serde_json::to_string_pretty(&round1_package).unwrap();
-    println!("{}", json);
+    println!("{json}");
 
     let decoded_round1_package: round1::Package = serde_json::from_str(&json).unwrap();
     assert!(round1_package == decoded_round1_package);
@@ -598,7 +598,7 @@ fn check_round2_package_serialization() {
     let round2_package = samples::round2_package();
 
     let json = serde_json::to_string_pretty(&round2_package).unwrap();
-    println!("{}", json);
+    println!("{json}");
 
     let decoded_round2_package: round2::Package = serde_json::from_str(&json).unwrap();
     assert!(round2_package == decoded_round2_package);
diff --git a/frost-ristretto255/tests/common_traits_tests.rs b/frost-ristretto255/tests/common_traits_tests.rs
@@ -9,7 +9,7 @@ use helpers::samples;
 fn check_common_traits_for_type<T: Clone + Eq + PartialEq + std::fmt::Debug>(v: T) {
     // Make sure can be debug-printed. This also catches if the Debug does not
     // have an endless recursion (a popular mistake).
-    println!("{:?}", v);
+    println!("{v:?}");
     // Test Clone and Eq
     assert_eq!(v, v.clone());
     // Make sure it can be unwrapped in a Result (which requires Debug).
diff --git a/frost-ristretto255/tests/serde_tests.rs b/frost-ristretto255/tests/serde_tests.rs
@@ -19,7 +19,7 @@ fn check_signing_commitments_serialization() {
     let commitments = samples::signing_commitments();
 
     let json = serde_json::to_string_pretty(&commitments).unwrap();
-    println!("{}", json);
+    println!("{json}");
 
     let decoded_commitments: SigningCommitments = serde_json::from_str(&json).unwrap();
     assert!(commitments == decoded_commitments);
@@ -89,7 +89,7 @@ fn check_signing_package_serialization() {
     let signing_package = samples::signing_package();
 
     let json = serde_json::to_string_pretty(&signing_package).unwrap();
-    println!("{}", json);
+    println!("{json}");
 
     let decoded_signing_package: SigningPackage = serde_json::from_str(&json).unwrap();
     assert!(signing_package == decoded_signing_package);
@@ -204,7 +204,7 @@ fn check_signature_share_serialization() {
     let signature_share = samples::signature_share();
 
     let json = serde_json::to_string_pretty(&signature_share).unwrap();
-    println!("{}", json);
+    println!("{json}");
 
     let decoded_signature_share: SignatureShare = serde_json::from_str(&json).unwrap();
     assert!(signature_share == decoded_signature_share);
@@ -258,7 +258,7 @@ fn check_secret_share_serialization() {
     let secret_share = samples::secret_share();
 
     let json = serde_json::to_string_pretty(&secret_share).unwrap();
-    println!("{}", json);
+    println!("{json}");
 
     let decoded_secret_share: SecretShare = serde_json::from_str(&json).unwrap();
     assert!(secret_share == decoded_secret_share);
@@ -342,7 +342,7 @@ fn check_key_package_serialization() {
     let key_package = samples::key_package();
 
     let json = serde_json::to_string_pretty(&key_package).unwrap();
-    println!("{}", json);
+    println!("{json}");
 
     let decoded_key_package: KeyPackage = serde_json::from_str(&json).unwrap();
     assert!(key_package == decoded_key_package);
@@ -437,7 +437,7 @@ fn check_public_key_package_serialization() {
     let public_key_package = samples::public_key_package_new();
 
     let json = serde_json::to_string_pretty(&public_key_package).unwrap();
-    println!("{}", json);
+    println!("{json}");
 
     let decoded_public_key_package: PublicKeyPackage = serde_json::from_str(&json).unwrap();
     assert!(public_key_package == decoded_public_key_package);
@@ -532,7 +532,7 @@ fn check_round1_package_serialization() {
     let round1_package = samples::round1_package();
 
     let json = serde_json::to_string_pretty(&round1_package).unwrap();
-    println!("{}", json);
+    println!("{json}");
 
     let decoded_round1_package: round1::Package = serde_json::from_str(&json).unwrap();
     assert!(round1_package == decoded_round1_package);
@@ -598,7 +598,7 @@ fn check_round2_package_serialization() {
     let round2_package = samples::round2_package();
 
     let json = serde_json::to_string_pretty(&round2_package).unwrap();
-    println!("{}", json);
+    println!("{json}");
 
     let decoded_round2_package: round2::Package = serde_json::from_str(&json).unwrap();
     assert!(round2_package == decoded_round2_package);
diff --git a/frost-secp256k1-tr/tests/common_traits_tests.rs b/frost-secp256k1-tr/tests/common_traits_tests.rs
@@ -9,7 +9,7 @@ use helpers::samples;
 fn check_common_traits_for_type<T: Clone + Eq + PartialEq + std::fmt::Debug>(v: T) {
     // Make sure can be debug-printed. This also catches if the Debug does not
     // have an endless recursion (a popular mistake).
-    println!("{:?}", v);
+    println!("{v:?}");
     // Test Clone and Eq
     assert_eq!(v, v.clone());
     // Make sure it can be unwrapped in a Result (which requires Debug).
diff --git a/frost-secp256k1-tr/tests/serde_tests.rs b/frost-secp256k1-tr/tests/serde_tests.rs
diff --git a/frost-secp256k1/tests/common_traits_tests.rs b/frost-secp256k1/tests/common_traits_tests.rs
diff --git a/frost-secp256k1/tests/serde_tests.rs b/frost-secp256k1/tests/serde_tests.rs
diff --git a/gencode/src/main.rs b/gencode/src/main.rs

Original file line number	Diff line number	Diff line change
`@@ -415,7 +415,7 @@ where`
`415`	`415`	`SigningPackage {`
`416`	`416`	`header: Header::default(),`
`417`	`417`	`signing_commitments,`
`418`		`- signing_participants_groups: signing_participants_groups,`
	`418`	`+ signing_participants_groups,`
`419`	`419`	`message: message.to_vec(),`
`420`	`420`	`adaptor: None,`
`421`	`421`	`}`
`@@ -431,9 +431,9 @@ where`
`431`	`431`	`SigningPackage {`
`432`	`432`	`header: Header::default(),`
`433`	`433`	`signing_commitments,`
`434`		`- signing_participants_groups: signing_participants_groups,`
	`434`	`+ signing_participants_groups,`
`435`	`435`	`message: message.to_vec(),`
`436`		`- adaptor: adaptor,`
	`436`	`+ adaptor,`
`437`	`437`	`}`
`438`	`438`	`}`
`439`	`439`