Skip to content

Commit 6b619a9

Browse files
Upgrade to node 24 to enable trusted publishing (#495)
* upgrade to node 24 to enable trusted publishing * wip --------- Co-authored-by: Corey Martin <coreyn.martin@gmail.com>
1 parent 67bdaf4 commit 6b619a9

3 files changed

Lines changed: 9 additions & 8 deletions

File tree

.github/workflows/create-release-pr.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ jobs:
2626
run: "git branch --track main origin/main"
2727

2828
- name: Setup node
29-
uses: "actions/setup-node@v3"
29+
uses: "actions/setup-node@v4"
3030
env:
3131
SKIP_YARN_COREPACK_CHECK: true
3232
with:

.github/workflows/docs.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ jobs:
1515
- name: "Checkout"
1616
uses: "actions/checkout@v3"
1717
- name: "Setup Node"
18-
uses: "actions/setup-node@v3"
18+
uses: "actions/setup-node@v4"
1919
env:
2020
SKIP_YARN_COREPACK_CHECK: true
2121
with:

.github/workflows/test-release-sync.yaml

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ jobs:
3131
fetch-depth: 2
3232

3333
- name: "Setup Node"
34-
uses: "actions/setup-node@v3"
34+
uses: "actions/setup-node@v4"
3535
env:
3636
SKIP_YARN_COREPACK_CHECK: true
3737
with:
@@ -77,7 +77,7 @@ jobs:
7777
ref: ${{ needs.update-lock-file.outputs.VERIFIED_LOCK_COMMIT }}
7878

7979
- name: "Setup Node v${{ matrix.node-version }}"
80-
uses: "actions/setup-node@v3"
80+
uses: "actions/setup-node@v4"
8181
env:
8282
SKIP_YARN_COREPACK_CHECK: true
8383
with:
@@ -129,7 +129,7 @@ jobs:
129129
ref: ${{ needs.update-lock-file.outputs.VERIFIED_LOCK_COMMIT }}
130130

131131
- name: "Setup Node v${{ matrix.node-version }}"
132-
uses: "actions/setup-node@v3"
132+
uses: "actions/setup-node@v4"
133133
env:
134134
SKIP_YARN_COREPACK_CHECK: true
135135
with:
@@ -166,11 +166,13 @@ jobs:
166166
uses: actions/checkout@v3
167167

168168
- name: "Setup Node"
169-
uses: "actions/setup-node@v3"
169+
uses: "actions/setup-node@v4"
170170
env:
171171
SKIP_YARN_COREPACK_CHECK: true
172172
with:
173-
node-version-file: ".nvmrc"
173+
# npm trusted publishing requires node >=22.14.0
174+
node-version: "24"
175+
registry-url: "https://registry.npmjs.org"
174176

175177
- name: Install dependencies with yarn cache
176178
uses: ./.github/actions/yarn-nm-install
@@ -185,7 +187,6 @@ jobs:
185187
publish: yarn release
186188
env:
187189
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
188-
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
189190

190191
# If the Version Packages PR has been created in the changesets step we should check if our workspace
191192
# package.json files have been updated from dependency bumps and update the lock file if so:

0 commit comments

Comments
 (0)