Skip to content

Commit dd6304d

Browse files
github-actions[bot]coreymartinclaude
authored
Fix docs workflow: replace missing .nvmrc with explicit node version
* Fix docs (#506) * Fix docs workflow: replace missing .nvmrc with explicit node version (#505) * Fix docs workflow: replace missing .nvmrc with explicit node version The .nvmrc file was removed but the docs workflow still referenced it, causing the Documentation CI job to fail on every push to main. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Use node 22.x to match checks/build workflows Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Use node 20.x to match other workflows Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> * Request workflows permission for Copybara GitHub App token (#504) * [gha] Add workflows permission to Copybara GitHub App token The Copybara push to webdev was failing because the token lacked workflows permission, which is required to push branches that include changes to .github/workflows/ files. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * [gha] Remove --nogit-destination-rebase from Copybara to fix workflow push error The Copybara push to webdev was failing because the stale PR branch had a diff including .github/workflows/js.yaml changes (from main moving since the branch was created). Removing --nogit-destination-rebase lets Copybara rebase on latest main so the PR only diffs js/ files. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * [gha] Request workflows permission for Copybara GitHub App token The Copybara push to webdev fails because --nogit-destination-rebase keeps the PR branch on a stale base, causing the branch diff to include .github/workflows/js.yaml changes. Removing the flag isn't an option (it causes merge conflicts — see PRs #365, #380, #448, #449). Instead, request workflows:write permission on the token so the push can include workflow file diffs. The LIGHTSPARK_COPYBARA GitHub App also needs workflows permission enabled in its app settings. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Corey Martin <coreyn.martin@gmail.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 5599929 commit dd6304d

2 files changed

Lines changed: 4 additions & 1 deletion

File tree

.github/workflows/docs.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919
env:
2020
SKIP_YARN_COREPACK_CHECK: true
2121
with:
22-
node-version-file: ".nvmrc"
22+
node-version: "20.x"
2323
cache: "yarn"
2424
cache-dependency-path: "yarn.lock"
2525

.github/workflows/test-release-sync.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -283,6 +283,9 @@ jobs:
283283
repositories: |
284284
js-sdk
285285
webdev
286+
permissions: |
287+
contents: write
288+
workflows: write
286289
287290
- name: "Run Copybara"
288291
env:

0 commit comments

Comments
 (0)