Commit f5247b0
Updates to ui, lightspark-sdk (#473)
* [nage] add pagination design for DataManagerTable, add temp security log table (#19556)
- adds custom DataManagerTable for nage with common props
- adds temporary security log table to test pagination
- adds customization to Dropdown to allow showing the menu above the button


The pagination has a few different possible states:
1. show first and 2nd page and last

2. show current page if between those with ellipses

3. only show ellipses if there are pages between

Note:
Clicking on page numbers doesn't work if it's a later page that has not been queried yet. This is because we use cursor based pagination and trying to jump to a page is a limitation. We would have to query all pages in between which isn't scalable. For now just allowing clicking on previously seen pages instead
GitOrigin-RevId: 916311d5507ece64bedd26d3b39a2f0c527611d1
* [nage] add code section to DetailsPage (#19576)

GitOrigin-RevId: db09e1902f935af2d462c5334d2d8f3a40b59433
* CI update lock file for PR
* Cleanup ls-sdk client.ts (#19540)
GitOrigin-RevId: bbecc81cf1cc398f1e168299866fb5e3e1b13941
* Regenerate js-sdk objects (#19649)
GitOrigin-RevId: 5702e553a68bc5691fc389404c3d8058b1f87ba9
* Create old-knives-wish.md
* Create smart-ways-fetch.md
---------
Co-authored-by: Brian Siao Tick Chong <bsiaotickchong@gmail.com>
Co-authored-by: Lightspark Eng <engineering@lightspark.com>
Co-authored-by: Jason Wang <jason@lightspark.com>1 parent ffa04c4 commit f5247b0
19 files changed
Lines changed: 334 additions & 38 deletions
File tree
- .changeset
- packages
- lightspark-sdk/src
- objects
- tests/integration
- ui/src
- components
- DataManagerTable
- icons/central
- styles/tokens
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
45 | 45 | | |
46 | 46 | | |
47 | 47 | | |
| 48 | + | |
48 | 49 | | |
49 | 50 | | |
| 51 | + | |
50 | 52 | | |
51 | 53 | | |
52 | 54 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
791 | 791 | | |
792 | 792 | | |
793 | 793 | | |
794 | | - | |
| 794 | + | |
795 | 795 | | |
796 | 796 | | |
797 | 797 | | |
| |||
1820 | 1820 | | |
1821 | 1821 | | |
1822 | 1822 | | |
| 1823 | + | |
| 1824 | + | |
| 1825 | + | |
| 1826 | + | |
| 1827 | + | |
| 1828 | + | |
1823 | 1829 | | |
1824 | | - | |
| 1830 | + | |
1825 | 1831 | | |
1826 | 1832 | | |
1827 | 1833 | | |
| |||
1830 | 1836 | | |
1831 | 1837 | | |
1832 | 1838 | | |
| 1839 | + | |
1833 | 1840 | | |
1834 | 1841 | | |
1835 | 1842 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
25 | | - | |
26 | | - | |
| 25 | + | |
| 26 | + | |
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
20 | | - | |
21 | | - | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
22 | 23 | | |
23 | 24 | | |
24 | 25 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1444 | 1444 | | |
1445 | 1445 | | |
1446 | 1446 | | |
1447 | | - | |
| 1447 | + | |
1448 | 1448 | | |
1449 | 1449 | | |
1450 | 1450 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
19 | | - | |
20 | | - | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
21 | 22 | | |
22 | 23 | | |
23 | 24 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
3 | 6 | | |
4 | 7 | | |
5 | 8 | | |
6 | | - | |
| 9 | + | |
7 | 10 | | |
8 | 11 | | |
9 | 12 | | |
10 | 13 | | |
11 | 14 | | |
12 | | - | |
| 15 | + | |
13 | 16 | | |
14 | 17 | | |
15 | 18 | | |
16 | 19 | | |
17 | 20 | | |
18 | | - | |
| 21 | + | |
19 | 22 | | |
20 | 23 | | |
21 | 24 | | |
| |||
24 | 27 | | |
25 | 28 | | |
26 | 29 | | |
27 | | - | |
| 30 | + | |
28 | 31 | | |
29 | 32 | | |
30 | 33 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
139 | 139 | | |
140 | 140 | | |
141 | 141 | | |
142 | | - | |
| 142 | + | |
143 | 143 | | |
144 | 144 | | |
145 | 145 | | |
| |||
0 commit comments