remove assertions in endpoint code, move to if checks

Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>

Author: Jdubrick

src/app/endpoints/saved_prompts.py

@@ -2,7 +2,7 @@
 
 from typing import Annotated, Any
 
-from fastapi import APIRouter, Depends, Request
+from fastapi import APIRouter, Depends, HTTPException, Request
 
 from authentication import get_auth_dependency
 from authentication.interface import AuthTuple
@@ -72,9 +72,14 @@ async def get_saved_prompts_config_handler(
     max_prompts_per_user = saved_prompts_config.max_prompts_per_user
     max_display_name_length = saved_prompts_config.max_display_name_length
     max_content_length = saved_prompts_config.max_content_length
-    assert max_prompts_per_user is not None
-    assert max_display_name_length is not None
-    assert max_content_length is not None
+    if (
+        max_prompts_per_user is None
+        or max_display_name_length is None
+        or max_content_length is None
+    ):
+        logger.error("Saved prompts configuration limits are not set")
+        error_response = InternalServerErrorResponse.generic()
+        raise HTTPException(**error_response.model_dump())
 
     return SavedPromptsConfigResponse(
         max_prompts_per_user=max_prompts_per_user,

tests/unit/app/endpoints/test_saved_prompts.py

@@ -127,6 +127,34 @@ async def test_get_saved_prompts_config_configuration_not_loaded(
     )
 
 
+@pytest.mark.asyncio
+async def test_get_saved_prompts_config_incomplete_limits(
+    mocker: MockerFixture,
+    minimal_config: AppConfig,
+    saved_prompts_http_request: Request,
+) -> None:
+    """GET /saved-prompts/config returns 500 when a limit is unexpectedly None.
+
+    The model validator on ``SavedPromptsConfiguration`` always fills in
+    defaults, so this simulates the defensive branch that guards against a
+    limit slipping through as ``None`` at runtime.
+    """
+    mock_authorization_resolvers(mocker)
+    minimal_config.configuration.saved_prompts.max_prompts_per_user = None
+    mocker.patch("app.endpoints.saved_prompts.configuration", minimal_config)
+
+    with pytest.raises(HTTPException) as exc_info:
+        await get_saved_prompts_config_handler(
+            auth=MOCK_AUTH,
+            request=saved_prompts_http_request,
+        )
+
+    assert exc_info.value.status_code == status.HTTP_500_INTERNAL_SERVER_ERROR
+    detail = exc_info.value.detail
+    assert isinstance(detail, dict)
+    assert detail["response"] == "Internal server error"  # type: ignore[index]
+
+
 @pytest.mark.asyncio
 async def test_get_saved_prompts_config_forbidden_without_get_config_action(
     mocker: MockerFixture,