Merge pull request #1362 from anik120/integration-test-conversation-endpoints

LCORE-716: integration tests for conversation management endpoints

Author: tisnik

tests/integration/conftest.py

@@ -29,9 +29,11 @@
 TEST_USER_ID = "00000000-0000-0000-0000-000"
 TEST_USERNAME = "lightspeed-user"
 TEST_CONVERSATION_ID = "a1b2c3d4-e5f6-7890-abcd-ef1234567890"
+TEST_SECOND_CONVERSATION_ID = "22222222-2222-2222-2222-222222222222"
 TEST_REQUEST_ID = "123e4567-e89b-12d3-a456-426614174000"
 TEST_OTHER_USER_ID = "11111111-1111-1111-1111-111111111111"
 TEST_NON_EXISTENT_ID = "00000000-0000-0000-0000-000000000001"
+TEST_INVALID_ID = "invalid-id-format"
 
 # Test Model/Provider
 TEST_MODEL = "test-provider/test-model"
@@ -303,6 +305,39 @@ async def test_auth_fixture(test_request: Request) -> AuthTuple:
     return await noop_auth(test_request)
 
 
+@pytest.fixture(name="non_admin_test_request")
+def non_admin_test_request_fixture(
+    test_request: Request, mocker: Any
+) -> Generator[Request, None, None]:
+    """Create a test request with standard user permissions (no elevated OTHERS permissions).
+
+    This fixture patches the authorization system to grant only standard user actions,
+    excluding elevated permissions like LIST_OTHERS_CONVERSATIONS, DELETE_OTHERS_CONVERSATIONS, etc.
+    This allows testing user isolation in integration tests.
+
+    Parameters:
+        test_request: Base request fixture
+        mocker: pytest-mock fixture
+
+    Yields:
+        Request: Test request that will have limited permissions when used with @authorize decorator
+    """
+    # Define standard user actions (excluding OTHERS and ADMIN permissions)
+    standard_actions = {
+        Action.LIST_CONVERSATIONS,
+        Action.GET_CONVERSATION,
+        Action.DELETE_CONVERSATION,
+        Action.UPDATE_CONVERSATION,
+    }
+
+    # Patch the NoopAccessResolver to return limited actions
+    mocker.patch(
+        "authorization.resolvers.NoopAccessResolver.get_actions",
+        return_value=standard_actions,
+    )
+    yield test_request
+
+
 @pytest.fixture(name="integration_http_client")
 def integration_http_client_fixture(
     test_config: object,
@@ -419,9 +454,12 @@ def mock_llama_stack_client_fixture(
 
     # Patch AsyncLlamaStackClientHolder at multiple import locations
     # This ensures the mock is active both during app startup (app.main)
-    # and during endpoint execution (app.endpoints.query)
+    # and during endpoint execution (query, conversations_v1, responses, etc.)
     mock_holder_class = mocker.patch("app.endpoints.query.AsyncLlamaStackClientHolder")
     mocker.patch("app.main.AsyncLlamaStackClientHolder", mock_holder_class)
+    mocker.patch(
+        "app.endpoints.conversations_v1.AsyncLlamaStackClientHolder", mock_holder_class
+    )
 
     mock_client = mocker.AsyncMock()