Skip to content

Commit 1afd720

Browse files
committed
addressed comments (clarification of customers vs product teams)
1 parent 9b907c8 commit 1afd720

2 files changed

Lines changed: 13 additions & 9 deletions

File tree

docs/design/agent-skills/agent-skills-spike.md

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,13 @@ These are the high-level decisions that determine scope, approach, and cost. Eac
1616

1717
| Option | Description |
1818
|--------|-------------|
19-
| A | Built-in skills only (Lightspeed developers ship pre-defined skills) |
20-
| B | Customer-defined only (end users import their own skill definitions) |
21-
| C | Both built-in and customer-defined |
19+
| A | Built-in skills only (Lightspeed Core developers ship pre-defined skills) |
20+
| B | Product team-defined only (LS app teams like RHEL Lightspeed define their own skills) |
21+
| C | Both built-in and product team-defined |
2222

23-
**Recommendation**: **B** (Customer-defined only). This allows end users to extend Lightspeed with their own domain expertise without requiring changes to the core product. Built-in skills can be added later if needed.
23+
**Recommendation**: **B** (Product team-defined only). This allows LS app teams (e.g., RHEL Lightspeed, Ansible Lightspeed) to extend Lightspeed with domain-specific skills without requiring changes to Lightspeed Core. Product teams ship skills alongside the lightspeed-stack container by mounting skill directories via configmaps or container volumes, then pointing to them in `lightspeed-stack.yaml`. Built-in skills can be added to Lightspeed Core later if common patterns emerge.
24+
25+
**Note**: End users of LS app products do NOT have the ability to add skills, similar to how they cannot add MCP servers. Skill configuration is controlled by product teams at deployment time.
2426

2527
### Decision 2: Discovery mechanism?
2628

@@ -29,7 +31,7 @@ These are the high-level decisions that determine scope, approach, and cost. Eac
2931
| A | Filesystem-based (scan configured directories for `SKILL.md` files) |
3032
| B | Config-based (define skills in `lightspeed-stack.yaml`) |
3133
| C | API-based (skills registered/managed via REST API) |
32-
| D | Hybrid (built-in via config, customer-defined via filesystem or API) |
34+
| D | Hybrid (built-in via config, product team-defined via filesystem or API) |
3335

3436
**Recommendation**: **B** (Config-based). Skills are defined in `lightspeed-stack.yaml` similar to `mcp_servers`. This provides explicit control over which skills are available, integrates with existing configuration patterns, and avoids filesystem scanning complexity.
3537

@@ -332,7 +334,7 @@ OpenAI's SDK already includes `LocalSkill` and `Skill` types in its responses mo
332334

333335
**Path restrictions**: The `activate_skill` tool and reference file access are restricted to configured skill directories. The LLM cannot access arbitrary filesystem paths through skills.
334336

335-
**Trust model**: Since skills are configured by administrators in `lightspeed-stack.yaml`, there's an implicit trust that configured skill paths contain appropriate content.
337+
**Trust model**: Skills are configured by LS app teams (e.g., RHEL Lightspeed) at deployment time, not by end users. Product teams mount skill directories into the container via configmaps or volumes and reference them in `lightspeed-stack.yaml`. This mirrors the MCP server trust model — end users cannot add arbitrary skills, only use the skills their product team has deployed.
336338

337339
## Appendix A: Existing approaches research
338340

docs/design/agent-skills/agent-skills.md

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,9 @@
1111

1212
## What
1313

14-
Agent Skills support allows customers to extend Lightspeed Core with specialized instructions and domain knowledge packaged as portable skill directories. Skills follow the [Agent Skills open standard](https://agentskills.io) and are configured in `lightspeed-stack.yaml`.
14+
Agent Skills support allows LS app teams (e.g., RHEL Lightspeed, Ansible Lightspeed) to extend Lightspeed Core with specialized instructions and domain knowledge packaged as portable skill directories. Skills follow the [Agent Skills open standard](https://agentskills.io) and are configured in `lightspeed-stack.yaml`. Product teams ship skills alongside the lightspeed-stack container by mounting skill directories via configmaps or container volumes.
15+
16+
**Note**: End users of LS app products do NOT have the ability to add skills, similar to how they cannot add MCP servers. Skill configuration is controlled by product teams at deployment time.
1517

1618
The LLM sees a skill catalog (name + description) in the system prompt and can load full instructions on demand using the `activate_skill` tool.
1719

@@ -43,10 +45,10 @@ Skills solve this by giving the LLM access to procedural knowledge and domain-sp
4345

4446
## Use Cases
4547

46-
- **U1:** As a platform administrator, I want to configure troubleshooting skills so that the LLM can help users diagnose common issues
48+
- **U1:** As an LS app team administrator, I want to configure troubleshooting skills so that the LLM can help users diagnose common issues
4749
- **U2:** As a skill author, I want to create a SKILL.md file with instructions so that I can package domain expertise portably
4850
- **U3:** As a user, I want the LLM to automatically use relevant skills so that I get better answers without manually specifying which skill to use
49-
- **U4:** As an enterprise customer, I want to deploy custom skills so that the LLM understands our internal processes and terminology
51+
- **U4:** As an LS app team, I want to deploy domain-specific skills so that the LLM understands product-specific processes and terminology
5052

5153
## Architecture
5254

0 commit comments

Comments
 (0)