LCORE-1724: fix vllm-extra-args quoting with shell functions

Use shell functions instead of variable expansion to preserve
quoting of --vllm-extra-args.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: are-ces

.tekton/integration-tests/pipeline/lightspeed-stack-rhelai-test.yaml

@@ -118,32 +118,41 @@ spec:
               echo "[mapt] Spot: $(params.spot)"
               echo "[mapt] =================================="
 
-              MAPT_COMMON_ARGS="--project-name mapt-rhel-ai-${RUN_ID} \
-                    --backed-url s3://${BUCKET}/mapt/rhel-ai/${RUN_ID} \
+              VLLM_EXTRA="--max-model-len 131072 --enable-auto-tool-choice --tool-call-parser llama3_json --chat-template /opt/app-root/template/tool_chat_template_llama3.1_json.jinja"
+              CREATED=0
+
+              mapt_create() {
+                mapt aws rhel-ai create \
+                    --project-name "mapt-rhel-ai-${RUN_ID}" \
+                    --backed-url "s3://${BUCKET}/mapt/rhel-ai/${RUN_ID}" \
                     --conn-details-output /opt/host-info \
-                    --compute-sizes $(params.instance-type) \
-                    --version $(params.rhelai-version) \
+                    --compute-sizes "$(params.instance-type)" \
+                    --version "$(params.rhelai-version)" \
                     --auto-start \
-                    --model $(params.model) \
-                    --hf-token ${HF_TOKEN} \
-                    --api-key ${VLLM_API_KEY} \
+                    --model "$(params.model)" \
+                    --hf-token "${HF_TOKEN}" \
+                    --api-key "${VLLM_API_KEY}" \
                     --expose-ports 8000 \
-                    --vllm-extra-args '--max-model-len 131072 --enable-auto-tool-choice --tool-call-parser llama3_json --chat-template /opt/app-root/template/tool_chat_template_llama3.1_json.jinja' \
-                    --tags project=lightspeed-core,environment=konflux-ci"
+                    --vllm-extra-args "${VLLM_EXTRA}" \
+                    --tags "project=lightspeed-core,environment=konflux-ci" \
+                    "$@"
+              }
 
-              CREATED=0
+              mapt_destroy() {
+                mapt aws rhel-ai destroy \
+                    --project-name "mapt-rhel-ai-${RUN_ID}" \
+                    --backed-url "s3://${BUCKET}/mapt/rhel-ai/${RUN_ID}" \
+                    --force-destroy 2>/dev/null || true
+              }
 
               # Try spot first
               echo "[mapt] Trying spot instances..."
               export AWS_DEFAULT_REGION="us-east-1"
-              if mapt aws rhel-ai create $MAPT_COMMON_ARGS --spot --spot-eviction-tolerance highest; then
+              if mapt_create --spot --spot-eviction-tolerance highest; then
                 CREATED=1
               else
                 echo "[mapt] Spot failed, cleaning up..."
-                mapt aws rhel-ai destroy \
-                    --project-name "mapt-rhel-ai-${RUN_ID}" \
-                    --backed-url "s3://${BUCKET}/mapt/rhel-ai/${RUN_ID}" \
-                    --force-destroy 2>/dev/null || true
+                mapt_destroy
               fi
 
               # Fall back to on-demand with region rotation
@@ -155,16 +164,13 @@ spec:
                   echo "[mapt] Trying on-demand in ${REGION}..."
                   export AWS_DEFAULT_REGION="$REGION"
 
-                  if timeout $TIMEOUT mapt aws rhel-ai create $MAPT_COMMON_ARGS; then
+                  if timeout $TIMEOUT mapt_create; then
                     CREATED=1
                     break
                   fi
 
                   echo "[mapt] Failed in ${REGION}, cleaning up..."
-                  mapt aws rhel-ai destroy \
-                      --project-name "mapt-rhel-ai-${RUN_ID}" \
-                      --backed-url "s3://${BUCKET}/mapt/rhel-ai/${RUN_ID}" \
-                      --force-destroy 2>/dev/null || true
+                  mapt_destroy
                 done
               fi