Skip to content

Commit 2517935

Browse files
committed
fix(logging): attach RichHandler before level validation and reduce fragile hardcoded names
Address review feedback: move RichHandler attachment before log level validation so warnings use consistent formatting, use module.__name__ instead of hardcoded logger name string in tests, and fix stale logger reference in A2A docs. Signed-off-by: Major Hayden <major@redhat.com>
1 parent 0f439fb commit 2517935

3 files changed

Lines changed: 7 additions & 4 deletions

File tree

docs/a2a_protocol.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -771,7 +771,7 @@ service:
771771
color_log: true
772772
```
773773

774-
Check logs for entries from `app.endpoints.health` logger.
774+
Check logs for entries from `app.endpoints.a2a` logger.
775775

776776
## Protocol Version
777777

src/log.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,10 @@ def get_logger(name: str) -> logging.Logger:
2828
if any(isinstance(h, RichHandler) for h in logger.handlers):
2929
return logger
3030

31+
# Attach RichHandler before any log calls so warnings use consistent formatting
32+
logger.handlers = [RichHandler()]
33+
logger.propagate = False
34+
3135
# Read log level from environment variable with default fallback
3236
level_str = os.environ.get(LIGHTSPEED_STACK_LOG_LEVEL_ENV_VAR, DEFAULT_LOG_LEVEL)
3337

@@ -42,6 +46,4 @@ def get_logger(name: str) -> logging.Logger:
4246
validated_level = getattr(logging, DEFAULT_LOG_LEVEL)
4347

4448
logger.setLevel(validated_level)
45-
logger.handlers = [RichHandler()]
46-
logger.propagate = False
4749
return logger

tests/unit/authorization/test_azure_token_manager.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
from pydantic import SecretStr
1313
from pytest_mock import MockerFixture
1414

15+
from authorization import azure_token_manager
1516
from authorization.azure_token_manager import (
1617
AzureEntraIDManager,
1718
TOKEN_EXPIRATION_LEEWAY,
@@ -136,7 +137,7 @@ def test_refresh_token_failure_logs_error(
136137
return_value=mock_credential_instance,
137138
)
138139

139-
azure_logger = logging.getLogger("authorization.azure_token_manager")
140+
azure_logger = logging.getLogger(azure_token_manager.__name__)
140141
azure_logger.propagate = True
141142
try:
142143
with caplog.at_level("WARNING"):

0 commit comments

Comments
 (0)