Merge pull request #1803 from tisnik/lcore-2334-use-specific-rule-codes-2

LCORE-2334: use specific rule codes

Author: tisnik

tests/unit/cache/test_sqlite_cache.py

@@ -154,7 +154,7 @@ def test_connected_when_connection_error(tmpdir: Path) -> None:
     # simulate connection error
     cache = create_cache(tmpdir)
     # connection can have any type
-    cache.connection = ConnectionMock()  # pyright: ignore
+    cache.connection = ConnectionMock()  # pyright: ignore[reportAttributeAccessIssue]
     assert cache.connection is not None
     assert cache.connected() is False
 

tests/unit/models/requests/test_vector_store_requests.py

@@ -86,7 +86,7 @@ def test_attributes_max_16_pairs(self) -> None:
         request = VectorStoreFileCreateRequest(
             file_id="file-abc123", attributes=attributes, chunking_strategy=None
         )
-        assert len(request.attributes) == 16  # type: ignore
+        assert len(request.attributes) == 16  # pyright: ignore[reportArgumentType]
 
     def test_attributes_exceeds_16_pairs(self) -> None:
         """Test that attributes with more than 16 pairs is rejected."""
@@ -107,7 +107,9 @@ def test_attributes_key_max_64_chars(self) -> None:
         request = VectorStoreFileCreateRequest(
             file_id="file-abc123", attributes=attributes, chunking_strategy=None
         )
-        assert key_64_chars in request.attributes  # type: ignore
+        assert (
+            key_64_chars in request.attributes
+        )  # pyright: ignore[reportOperatorIssue]
 
     def test_attributes_key_exceeds_64_chars(self) -> None:
         """Test that attribute keys exceeding 64 characters are rejected."""
@@ -125,7 +127,9 @@ def test_attributes_string_value_max_512_chars(self) -> None:
         request = VectorStoreFileCreateRequest(
             file_id="file-abc123", attributes=attributes, chunking_strategy=None
         )
-        assert request.attributes["key"] == value_512_chars  # type: ignore
+        assert isinstance(request.attributes, dict)
+        assert "key" in request.attributes
+        assert request.attributes["key"] == value_512_chars
 
     def test_attributes_string_value_exceeds_512_chars(self) -> None:
         """Test that string attribute values exceeding 512 characters are rejected."""
@@ -170,7 +174,7 @@ def test_attributes_none_is_valid(self) -> None:
     def test_file_id_required(self) -> None:
         """Test that file_id is required."""
         with pytest.raises(ValidationError):
-            VectorStoreFileCreateRequest()  # type: ignore
+            VectorStoreFileCreateRequest()  # pyright: ignore[reportCallIssue]
 
     def test_file_id_cannot_be_empty(self) -> None:
         """Test that file_id cannot be an empty string."""

tests/unit/quota/test_quota_limiter_factory.py

@@ -40,7 +40,7 @@ def test_quota_limiters_no_limiters_pg_storage() -> None:
         gss_encmode=constants.POSTGRES_DEFAULT_GSS_ENCMODE,
         ca_cert_path=None,
     )
-    configuration.limiters = None  # pyright: ignore
+    configuration.limiters = None  # pyright: ignore[reportAttributeAccessIssue]
     limiters = QuotaLimiterFactory.quota_limiters(configuration)
     assert not limiters
 
@@ -51,7 +51,7 @@ def test_quota_limiters_no_limiters_sqlite_storage() -> None:
     configuration.sqlite = SQLiteDatabaseConfiguration(
         db_path="/foo/bar",
     )
-    configuration.limiters = None  # pyright: ignore
+    configuration.limiters = None  # pyright: ignore[reportAttributeAccessIssue]
     limiters = QuotaLimiterFactory.quota_limiters(configuration)
     assert not limiters
 
@@ -274,7 +274,9 @@ def test_quota_limiters_invalid_limiter_type(mocker: MockerFixture) -> None:
             period="5 days",
         ),
     ]
-    configuration.limiters[0].type = "foo"  # pyright: ignore
+    configuration.limiters[0].type = (
+        "foo"  # pyright: ignore[reportAttributeAccessIssue]
+    )
     # do not use connection to real PostgreSQL instance
     mocker.patch("psycopg2.connect")
     with pytest.raises(ValueError, match="Invalid limiter type: foo"):