Remove the logic flaw in get_vector_store_ids

Author: Jazzcort

src/utils/responses.py

@@ -129,17 +129,11 @@
 
 async def get_vector_store_ids(
     client: AsyncLlamaStackClient,
-    vector_store_ids: Optional[list[str]] = None,
 ) -> list[str]:
-    """Get vector store IDs for querying.
-
-    If vector_store_ids are provided, returns them. Otherwise fetches all
-    available vector stores from Llama Stack.
+    """Fetche all available vector stores from Llama Stack.
 
     Args:
         client: The AsyncLlamaStackClient to use for fetching stores
-        vector_store_ids: Optional list of vector store IDs. If provided,
-            returns this list. If None, fetches all available vector stores.
 
     Returns:
         List of vector store IDs to query
@@ -148,9 +142,6 @@ async def get_vector_store_ids(
         HTTPException: With ServiceUnavailableResponse if connection fails,
             or InternalServerErrorResponse if API returns an error status
     """
-    if vector_store_ids is not None:
-        return vector_store_ids
-
     try:
         vector_stores = await client.vector_stores.list()
         return [vector_store.id for vector_store in vector_stores.data]

tests/unit/utils/test_responses.py

@@ -2150,9 +2150,9 @@ async def test_prepare_responses_params_includes_mcp_provider_data_headers(
 
         # The result should contain extra_headers with x-llamastack-provider-data
         dumped = result.model_dump()
-        assert (
-            dumped["extra_headers"] is not None
-        ), "extra_headers should not be None when MCP tools have headers"
+        assert dumped["extra_headers"] is not None, (
+            "extra_headers should not be None when MCP tools have headers"
+        )
         assert "x-llamastack-provider-data" in dumped["extra_headers"]
 
         provider_data = json.loads(
@@ -3148,14 +3148,6 @@ def test_multiple_stores_source_is_none(self, mocker: MockerFixture) -> None:
 class TestGetVectorStoreIds:
     """Tests for get_vector_store_ids utility function."""
 
-    @pytest.mark.asyncio
-    async def test_returns_provided_ids_directly(self, mocker: MockerFixture) -> None:
-        """Test that provided vector_store_ids are returned without fetching."""
-        client_mock = mocker.AsyncMock()
-        result = await get_vector_store_ids(client_mock, ["vs1", "vs2"])
-        assert result == ["vs1", "vs2"]
-        client_mock.vector_stores.list.assert_not_called()
-
     @pytest.mark.asyncio
     async def test_fetches_all_when_no_ids_provided(
         self, mocker: MockerFixture
@@ -3172,7 +3164,7 @@ async def test_fetches_all_when_no_ids_provided(
         client_mock = mocker.AsyncMock()
         client_mock.vector_stores.list.return_value = mock_list_result
 
-        result = await get_vector_store_ids(client_mock, None)
+        result = await get_vector_store_ids(client_mock)
         assert result == ["vs-fetched-1", "vs-fetched-2"]
         client_mock.vector_stores.list.assert_called_once()
 
@@ -3185,7 +3177,7 @@ async def test_raises_on_connection_error(self, mocker: MockerFixture) -> None:
         )
 
         with pytest.raises(HTTPException) as exc_info:
-            await get_vector_store_ids(client_mock, None)
+            await get_vector_store_ids(client_mock)
         assert exc_info.value.status_code == 503
 
     @pytest.mark.asyncio
@@ -3202,7 +3194,7 @@ async def test_raises_on_api_status_error(self, mocker: MockerFixture) -> None:
         )
 
         with pytest.raises(HTTPException) as exc_info:
-            await get_vector_store_ids(client_mock, None)
+            await get_vector_store_ids(client_mock)
         assert exc_info.value.status_code == 500