added unit tests for the extra logic

Author: Radovan Fuchs

tests/unit/app/endpoints/test_query.py

@@ -2261,3 +2261,108 @@ async def test_get_topic_summary_create_turn_parameters(mocker: MockerFixture) -
         stream=False,
         toolgroups=None,
     )
+
+
+@pytest.mark.asyncio
+async def test_query_endpoint_generate_topic_summary_default_true(
+    mocker: MockerFixture, dummy_request: Request
+) -> None:
+    """Test that topic summary is generated by default for new conversations."""
+    mock_client = mocker.AsyncMock()
+    mock_lsc = mocker.patch("client.AsyncLlamaStackClientHolder.get_client")
+    mock_lsc.return_value = mock_client
+    mock_client.models.list.return_value = [
+        mocker.Mock(identifier="model1", model_type="llm", provider_id="provider1"),
+    ]
+
+    mock_config = mocker.Mock()
+    mock_config.quota_limiters = []
+    mocker.patch("app.endpoints.query.configuration", mock_config)
+
+    summary = TurnSummary(llm_response="Test response", tool_calls=[])
+    mocker.patch(
+        "app.endpoints.query.retrieve_response",
+        return_value=(
+            summary,
+            "00000000-0000-0000-0000-000000000000",
+            [],
+            TokenCounter(),
+        ),
+    )
+
+    mocker.patch(
+        "app.endpoints.query.select_model_and_provider_id",
+        return_value=("test_model", "test_model", "test_provider"),
+    )
+    mocker.patch("app.endpoints.query.is_transcripts_enabled", return_value=False)
+    
+    # Mock get_topic_summary - this SHOULD be called
+    mock_get_topic_summary = mocker.patch(
+        "app.endpoints.query.get_topic_summary", return_value="Generated topic"
+    )
+    
+    # Mock database operations
+    mock_database_operations(mocker)
+
+    # Call without specifying generate_topic_summary (defaults to True)
+    await query_endpoint_handler(
+        request=dummy_request,
+        query_request=QueryRequest(query="test query"),
+        auth=("user123", "username", False, "auth_token_123"),
+        mcp_headers={},
+    )
+
+    mock_get_topic_summary.assert_called_once()
+
+
+@pytest.mark.asyncio
+async def test_query_endpoint_generate_topic_summary_explicit_false(
+    mocker: MockerFixture, dummy_request: Request
+) -> None:
+    """Test that topic summary is NOT generated when explicitly set to False."""
+    mock_client = mocker.AsyncMock()
+    mock_lsc = mocker.patch("client.AsyncLlamaStackClientHolder.get_client")
+    mock_lsc.return_value = mock_client
+    mock_client.models.list.return_value = [
+        mocker.Mock(identifier="model1", model_type="llm", provider_id="provider1"),
+    ]
+
+    mock_config = mocker.Mock()
+    mock_config.quota_limiters = []
+    mocker.patch("app.endpoints.query.configuration", mock_config)
+
+    summary = TurnSummary(llm_response="Test response", tool_calls=[])
+    mocker.patch(
+        "app.endpoints.query.retrieve_response",
+        return_value=(
+            summary,
+            "00000000-0000-0000-0000-000000000000",
+            [],
+            TokenCounter(),
+        ),
+    )
+
+    mocker.patch(
+        "app.endpoints.query.select_model_and_provider_id",
+        return_value=("test_model", "test_model", "test_provider"),
+    )
+    mocker.patch("app.endpoints.query.is_transcripts_enabled", return_value=False)
+    
+    # Mock get_topic_summary - this should NOT be called
+    mock_get_topic_summary = mocker.patch(
+        "app.endpoints.query.get_topic_summary", return_value="Generated topic"
+    )
+    
+    # Mock database operations
+    mock_database_operations(mocker)
+
+    # Call with generate_topic_summary=False
+    await query_endpoint_handler(
+        request=dummy_request,
+        query_request=QueryRequest(query="test query", generate_topic_summary=False),
+        auth=("user123", "username", False, "auth_token_123"),
+        mcp_headers={},
+    )
+
+    # Verify get_topic_summary was NOT called
+    mock_get_topic_summary.assert_not_called()

tests/unit/models/requests/test_query_request.py

@@ -154,3 +154,16 @@ def test_validate_media_type(self, mocker: MockerFixture) -> None:
 
         # Media type is now fully supported, no warning expected
         mock_logger.warning.assert_not_called()
+
+
+    def test_generate_topic_summary_explicit_false(self) -> None:
+        """Test that generate_topic_summary can be explicitly set to False."""
+        qr = QueryRequest(
+            query="Tell me about Kubernetes", generate_topic_summary=False
+        )
+        assert qr.generate_topic_summary is False
+
+    def test_generate_topic_summary_explicit_true(self) -> None:
+        """Test that generate_topic_summary can be explicitly set to True."""
+        qr = QueryRequest(query="Tell me about Kubernetes", generate_topic_summary=True)
+        assert qr.generate_topic_summary is True