Skip to content

Commit 9b907c8

Browse files
committed
addressed comments (script support)
1 parent 6208b62 commit 9b907c8

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

docs/design/agent-skills/agent-skills-spike.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ These are the high-level decisions that determine scope, approach, and cost. Eac
4141
| B | Scripts allowed (full spec compliance) |
4242
| C | Deferred (start with no scripts, add later) |
4343

44-
**Recommendation**: **A** (No scripts). As noted in LCORE-1339, there are security concerns with executing arbitrary scripts. The core value of skills is in the instructions — scripts can be added in a future phase after security review if needed.
44+
**Recommendation**: **C** (Deferred). As noted in LCORE-1339, there are security concerns with executing arbitrary scripts. Script support will not be implemented until sandbox support (running scripts in an isolated environment) is added. The core value of skills is in the instructions — scripts can be added in a future phase once sandboxing is available.
4545

4646
## Technical decisions for @ptisnovs
4747

@@ -328,7 +328,7 @@ OpenAI's SDK already includes `LocalSkill` and `Skill` types in its responses mo
328328

329329
### Security considerations
330330

331-
**Scripts excluded**: The `scripts/` subdirectory is not supported in this implementation. As noted in LCORE-1339, executing arbitrary scripts poses security risks. Skills provide value through instructions; script support can be evaluated in a future phase.
331+
**Scripts deferred**: The `scripts/` subdirectory is not supported in this implementation. As noted in LCORE-1339, executing arbitrary scripts poses security risks. Script support will be added in a future phase once sandbox support (running scripts in an isolated environment) is available.
332332

333333
**Path restrictions**: The `activate_skill` tool and reference file access are restricted to configured skill directories. The LLM cannot access arbitrary filesystem paths through skills.
334334

0 commit comments

Comments
 (0)