Skip to content

Commit a13b239

Browse files
author
Radovan Fuchs
committed
fix linter
1 parent 81b4b90 commit a13b239

5 files changed

Lines changed: 12 additions & 18 deletions

File tree

src/app/endpoints/query.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -314,14 +314,16 @@ async def query_endpoint_handler_base( # pylint: disable=R0914
314314
if not existing_conversation:
315315
# Check if topic summary should be generated (default: True)
316316
should_generate = query_request.generate_topic_summary
317-
317+
318318
if should_generate:
319319
logger.debug("Generating topic summary for new conversation")
320320
topic_summary = await get_topic_summary_func(
321321
query_request.query, client, llama_stack_model_id
322322
)
323323
else:
324-
logger.debug("Topic summary generation disabled by request parameter")
324+
logger.debug(
325+
"Topic summary generation disabled by request parameter"
326+
)
325327
topic_summary = None
326328
# Convert RAG chunks to dictionary format once for reuse
327329
logger.info("Processing RAG chunks...")

src/app/endpoints/streaming_query.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -864,14 +864,15 @@ async def response_generator(
864864
if not existing_conversation:
865865
# Check if topic summary should be generated (default: True)
866866
should_generate = query_request.generate_topic_summary
867-
868867
if should_generate:
869868
logger.debug("Generating topic summary for new conversation")
870869
topic_summary = await get_topic_summary(
871870
query_request.query, client, model_id
872871
)
873872
else:
874-
logger.debug("Topic summary generation disabled by request parameter")
873+
logger.debug(
874+
"Topic summary generation disabled by request parameter"
875+
)
875876
topic_summary = None
876877

877878
completed_at = datetime.now(UTC).strftime("%Y-%m-%dT%H:%M:%SZ")

src/models/requests.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ class QueryRequest(BaseModel):
8181
system_prompt: The optional system prompt.
8282
attachments: The optional attachments.
8383
no_tools: Whether to bypass all tools and MCP servers (default: False).
84-
generate_topic_summary: Whether to generate topic summary for new conversations (default: None = use server config).
84+
generate_topic_summary: Whether to generate topic summary for new conversations.
8585
media_type: The optional media type for response format (application/json or text/plain).
8686
8787
Example:
@@ -149,7 +149,7 @@ class QueryRequest(BaseModel):
149149

150150
generate_topic_summary: Optional[bool] = Field(
151151
True,
152-
description="Whether to generate topic summary for new conversations (None = use server config default)",
152+
description="Whether to generate topic summary for new conversations",
153153
examples=[True, False],
154154
)
155155

tests/unit/app/endpoints/test_query.py

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -2295,16 +2295,12 @@ async def test_query_endpoint_generate_topic_summary_default_true(
22952295
return_value=("test_model", "test_model", "test_provider"),
22962296
)
22972297
mocker.patch("app.endpoints.query.is_transcripts_enabled", return_value=False)
2298-
2299-
# Mock get_topic_summary - this SHOULD be called
2298+
23002299
mock_get_topic_summary = mocker.patch(
23012300
"app.endpoints.query.get_topic_summary", return_value="Generated topic"
23022301
)
2303-
2304-
# Mock database operations
23052302
mock_database_operations(mocker)
23062303

2307-
# Call without specifying generate_topic_summary (defaults to True)
23082304
await query_endpoint_handler(
23092305
request=dummy_request,
23102306
query_request=QueryRequest(query="test query"),
@@ -2347,22 +2343,18 @@ async def test_query_endpoint_generate_topic_summary_explicit_false(
23472343
return_value=("test_model", "test_model", "test_provider"),
23482344
)
23492345
mocker.patch("app.endpoints.query.is_transcripts_enabled", return_value=False)
2350-
2351-
# Mock get_topic_summary - this should NOT be called
2346+
23522347
mock_get_topic_summary = mocker.patch(
23532348
"app.endpoints.query.get_topic_summary", return_value="Generated topic"
23542349
)
2355-
2356-
# Mock database operations
2350+
23572351
mock_database_operations(mocker)
23582352

2359-
# Call with generate_topic_summary=False
23602353
await query_endpoint_handler(
23612354
request=dummy_request,
23622355
query_request=QueryRequest(query="test query", generate_topic_summary=False),
23632356
auth=("user123", "username", False, "auth_token_123"),
23642357
mcp_headers={},
23652358
)
23662359

2367-
# Verify get_topic_summary was NOT called
23682360
mock_get_topic_summary.assert_not_called()

tests/unit/models/requests/test_query_request.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,6 @@ def test_validate_media_type(self, mocker: MockerFixture) -> None:
155155
# Media type is now fully supported, no warning expected
156156
mock_logger.warning.assert_not_called()
157157

158-
159158
def test_generate_topic_summary_explicit_false(self) -> None:
160159
"""Test that generate_topic_summary can be explicitly set to False."""
161160
qr = QueryRequest(

0 commit comments

Comments
 (0)