Merge pull request #1089 from tisnik/lcore-887-fixed-pyright-issues-in-auth-tests

LCORE-887: fixed pyright issues in auth tests

Author: tisnik

tests/unit/authorization/test_azure_token_manager.py

@@ -25,6 +25,7 @@ def dummy_config_fixture() -> AzureEntraIdConfiguration:
         tenant_id=SecretStr("tenant"),
         client_id=SecretStr("client"),
         client_secret=SecretStr("secret"),
+        scope="https://cognitiveservices.azure.com/.default",
     )
 
 

tests/unit/authorization/test_middleware.py

@@ -85,6 +85,7 @@ def sample_role_rule(self) -> JwtRoleRule:
             operator=JsonPathOperator.EQUALS,
             value="test",
             roles=["test"],
+            negate=False,
         )
 
     @pytest.mark.parametrize(

tests/unit/authorization/test_resolvers.py

@@ -74,6 +74,7 @@ async def employee_role_rule(self) -> JwtRoleRule:
             operator=JsonPathOperator.CONTAINS,
             value="redhat:employees",
             roles=["employee"],
+            negate=False,
         )
 
     @pytest.fixture
@@ -178,6 +179,7 @@ async def email_rule_resolver(self) -> JwtRolesResolver:
                     operator=JsonPathOperator.MATCH,
                     value=r"@redhat\.com$",
                     roles=["redhat_employee"],
+                    negate=False,
                 )
             ]
         )
@@ -198,6 +200,7 @@ async def equals_rule_resolver(self) -> JwtRolesResolver:
                     operator=JsonPathOperator.EQUALS,
                     value=["bar"],
                     roles=["foobar"],
+                    negate=False,
                 )
             ]
         )
@@ -225,6 +228,7 @@ async def in_rule_resolver(self) -> JwtRolesResolver:
                     operator=JsonPathOperator.IN,
                     value=[["bar"], ["baz"]],
                     roles=["in_role"],
+                    negate=False,
                 )
             ]
         )
@@ -268,6 +272,7 @@ async def test_resolve_roles_match_operator_invalid_regex(self) -> None:
                 operator=JsonPathOperator.MATCH,
                 value="[invalid regex(",  # Invalid regex pattern
                 roles=["test_role"],
+                negate=False,
             )
 
     async def test_resolve_roles_match_operator_non_string_pattern(self) -> None:
@@ -280,6 +285,7 @@ async def test_resolve_roles_match_operator_non_string_pattern(self) -> None:
                 operator=JsonPathOperator.MATCH,
                 value=123,  # Non-string pattern
                 roles=["test_role"],
+                negate=False,
             )
 
     async def test_resolve_roles_match_operator_non_string_value(self) -> None:
@@ -290,6 +296,7 @@ async def test_resolve_roles_match_operator_non_string_value(self) -> None:
                 operator=JsonPathOperator.MATCH,
                 value=r"\d+",  # Number pattern
                 roles=["numeric_user"],
+                negate=False,
             )
         ]
         jwt_resolver = JwtRolesResolver(role_rules)
@@ -312,6 +319,7 @@ async def test_compiled_regex_property(self) -> None:
             operator=JsonPathOperator.MATCH,
             value=r"@example\.com$",
             roles=["example_user"],
+            negate=False,
         )
         assert match_rule.compiled_regex is not None
         assert isinstance(match_rule.compiled_regex, re.Pattern)
@@ -323,6 +331,7 @@ async def test_compiled_regex_property(self) -> None:
             operator=JsonPathOperator.EQUALS,
             value="test@example.com",
             roles=["example_user"],
+            negate=False,
         )
         assert equals_rule.compiled_regex is None
 
@@ -382,7 +391,7 @@ async def test_check_access_with_valid_role(self) -> None:
         assert has_access is True
 
         # Test access denied
-        has_access = resolver.check_access(Action.FEEDBACK, frozenset(["employee"]))
+        has_access = resolver.check_access(Action.FEEDBACK, {"employee"})
         assert has_access is False
 
     async def test_check_access_with_invalid_role(self) -> None: