Skip to content

Commit dcfe402

Browse files
committed
Improve None-path test to detect accidental BYOK translation
1 parent 54997f2 commit dcfe402

1 file changed

Lines changed: 5 additions & 4 deletions

File tree

tests/unit/utils/test_responses.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1106,17 +1106,18 @@ async def test_does_not_translate_when_ids_fetched_from_llama_stack(
11061106
)
11071107
mocker.patch("utils.responses.get_mcp_tools", return_value=None)
11081108

1109-
# Configure BYOK RAG (should NOT be used for the None path)
1109+
# Configure BYOK RAG whose rag_id matches the fetched ID so that
1110+
# accidental translation would change the result and fail the assertion
11101111
mock_byok_rag = mocker.Mock()
1111-
mock_byok_rag.rag_id = "ocp_docs"
1112-
mock_byok_rag.vector_db_id = "vs-internal"
1112+
mock_byok_rag.rag_id = "vs-internal"
1113+
mock_byok_rag.vector_db_id = "vs-translated"
11131114
mock_config = mocker.Mock()
11141115
mock_config.configuration.byok_rag = [mock_byok_rag]
11151116
mocker.patch("utils.responses.configuration", mock_config)
11161117

11171118
result = await prepare_tools(mock_client, None, False, "token")
11181119
assert result is not None
1119-
# The IDs from llama-stack should be used as-is
1120+
# The IDs from llama-stack should be used as-is (no BYOK translation on None path)
11201121
assert result[0].vector_store_ids == ["vs-internal"]
11211122

11221123

0 commit comments

Comments
 (0)