Commit f1c6cec
LCORE-1037: address review nits in BYOK and RAG guides (#1842)
- Replace pdm with uv for embedding model download command
- Remove unnecessary OpenAI API key note
- Fix Ollama section: clarify no tool RAG but inline RAG supported
- Remove empty References section from RAG guide
- Fix incorrect embedding dimensions for all-mpnet-base-v2 (768, not 1024/384)
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>1 parent 388ea35 commit f1c6cec
3 files changed
Lines changed: 4 additions & 16 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
161 | 161 | | |
162 | 162 | | |
163 | 163 | | |
164 | | - | |
| 164 | + | |
165 | 165 | | |
166 | 166 | | |
167 | 167 | | |
| |||
340 | 340 | | |
341 | 341 | | |
342 | 342 | | |
343 | | - | |
344 | | - | |
345 | | - | |
346 | | - | |
347 | 343 | | |
348 | 344 | | |
349 | 345 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
223 | 223 | | |
224 | 224 | | |
225 | 225 | | |
226 | | - | |
227 | | - | |
228 | | - | |
229 | | - | |
230 | | - | |
| 226 | + | |
231 | 227 | | |
232 | 228 | | |
233 | 229 | | |
| |||
386 | 382 | | |
387 | 383 | | |
388 | 384 | | |
389 | | - | |
390 | | - | |
391 | | - | |
392 | | - | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
41 | | - | |
| 41 | + | |
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
45 | 45 | | |
46 | 46 | | |
47 | 47 | | |
48 | | - | |
| 48 | + | |
49 | 49 | | |
50 | 50 | | |
51 | 51 | | |
| |||
0 commit comments