Skip to content

LCORE-1249: config for SQLite should be separated#1142

Merged
tisnik merged 1 commit into
lightspeed-core:mainfrom
tisnik:lcore-1249-config-for-sqlite
Feb 12, 2026
Merged

LCORE-1249: config for SQLite should be separated#1142
tisnik merged 1 commit into
lightspeed-core:mainfrom
tisnik:lcore-1249-config-for-sqlite

Conversation

@tisnik
Copy link
Copy Markdown
Contributor

@tisnik tisnik commented Feb 12, 2026

Description

LCORE-1249: config for SQLite should be separated

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change
  • Unit tests improvement
  • Integration tests improvement
  • End to end tests improvement
  • Benchmarks improvement

Tools used to create PR

  • Assisted-by: N/A
  • Generated by: N/A

Related Tickets & Documents

  • Related Issue #LCORE-1249

Summary by CodeRabbit

  • Tests
    • Updated benchmark test configuration to use an alternative database setup.

Note: This release contains only internal testing modifications with no user-facing changes.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Feb 12, 2026

Walkthrough

The benchmark test configuration has been updated to use a SQLite configuration file instead of a lightspeed-stack configuration file. The configuration_filename fixture now references benchmarks-sqlite.yaml, while all benchmark logic and database setup remain unchanged.

Changes

Cohort / File(s) Summary
Benchmark Configuration
tests/benchmarks/test_app_database.py
Updated fixture to return SQLite benchmark configuration file instead of lightspeed-stack configuration.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: switching the benchmark configuration from lightspeed-stack to SQLite-specific configuration, which aligns with the PR objective of separating SQLite configuration.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tisnik tisnik merged commit 5d1416c into lightspeed-core:main Feb 12, 2026
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant