LCORE-1249: comparison benchmarks update

[tisnik]

Description

LCORE-1249: comparison benchmarks update

Type of change

• Refactor
• New feature
• Bug fix
• CVE fix
• Optimization
• Documentation Update
• Configuration Update
• Bump-up service version
• Bump-up dependent library
• Bump-up library or tool used for development (does not change the final image)
• CI configuration change
• Konflux configuration change
• Unit tests improvement
• Integration tests improvement
• End to end tests improvement
• Benchmarks improvement

Tools used to create PR

• Assisted-by: N/A
• Generated by: N/A

Related Tickets & Documents

• Related Issue #LCORE-1249

Summary by CodeRabbit

• Tests
  • Updated benchmark test configuration with increased workload parameters to improve stress testing coverage.

[coderabbitai]

Walkthrough

A benchmark test function has been renamed to clarify its scope, and the database records count constant has been increased from 100 to 10000 to establish more intensive benchmark scenarios across all related tests.

Changes

Cohort / File(s)	Summary
Benchmark Configuration tests/benchmarks/test_app_database_comparison.py	Renamed test_retrieve_conversation to test_retrieve_conversation_for_all_users for clarity. Increased DB_RECORDS_COUNT from 100 to 10000 to create more demanding benchmark conditions.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main changes—updating comparison benchmarks including function rename and workload increase.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (1)

tests/benchmarks/test_app_database_comparison.py (1)

84-84: Minor grammar nit: "an small" → "a small".

Pre-existing typo, but since nearby lines are being touched, worth fixing.

-    """Benchmark listing conversations on an small database.
+    """Benchmark listing conversations on a small database.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@tests/benchmarks/test_app_database_comparison.py` at line 84, Fix the grammar
in the module/test docstring that currently reads "Benchmark listing
conversations on an small database." Change "an small" to "a small" in the
triple-quoted string so it reads "Benchmark listing conversations on a small
database." This is the only change needed; update the docstring where it appears
in the tests/benchmarks test module.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@tests/benchmarks/test_app_database_comparison.py`:
- Line 16: Docstrings in the benchmark tests still call the dataset a "small DB"
even though the constant DB_RECORDS_COUNT was increased to 10000; update all
test function docstrings to accurately describe a "large" or "10k-record"
database (referencing the DB_RECORDS_COUNT constant) and adjust any comments
that claim "small database". Also evaluate CI impact: either add a note or guard
to run a reduced-records mode in CI (e.g., via an environment flag) or revert to
a lower count for CI, and ensure any benchmark helper loops that iterate
DB_RECORDS_COUNT are not accidentally making CI unbearably slow.

---

Nitpick comments:
In `@tests/benchmarks/test_app_database_comparison.py`:
- Line 84: Fix the grammar in the module/test docstring that currently reads
"Benchmark listing conversations on an small database." Change "an small" to "a
small" in the triple-quoted string so it reads "Benchmark listing conversations
on a small database." This is the only change needed; update the docstring where
it appears in the tests/benchmarks test module.

[coderabbitai]

⚠️ Potential issue | 🟡 Minor

Docstrings now misrepresent the database size.

With DB_RECORDS_COUNT bumped from 100 to 10,000, the docstrings across all test functions still reference "small DB" / "small database" (e.g., lines 27, 46, 65, 84, 103, 122). These should be updated to reflect the new workload size.

Also, has the CI runtime impact of a 100× increase been assessed? Depending on how the benchmark helpers iterate, this could noticeably slow down the benchmark suite.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@tests/benchmarks/test_app_database_comparison.py` at line 16, Docstrings in
the benchmark tests still call the dataset a "small DB" even though the constant
DB_RECORDS_COUNT was increased to 10000; update all test function docstrings to
accurately describe a "large" or "10k-record" database (referencing the
DB_RECORDS_COUNT constant) and adjust any comments that claim "small database".
Also evaluate CI impact: either add a note or guard to run a reduced-records
mode in CI (e.g., via an environment flag) or revert to a lower count for CI,
and ensure any benchmark helper loops that iterate DB_RECORDS_COUNT are not
accidentally making CI unbearably slow.