LCORE-1413: Fixing MCP Authorization #1270
Closed
jrobertboos wants to merge 4 commits into
Closed
Conversation
- Changed the Llama stack URL to localhost for local development. - Added MCP server configuration with authorization headers. - Introduced a new utility function to build request bodies for the Responses API, ensuring proper authorization handling. - Updated response retrieval methods to utilize the new utility function. - Enhanced the MCP OAuth probing function to conditionally include authorization headers and only raise exceptions for 401 responses. - Modified the mock MCP server to handle authorization checks more effectively.
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
- Moved topic summary generation logic to prevent cancellation by MCP session cleanup. - Added error handling for topic summary generation in streaming response to ensure completion even on cancellation. - Removed redundant topic summary code from query endpoint handler. - Updated e2e tests for tools endpoint to include new authorization checks and response validation.
Contributor
Author
|
Duplicate |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of change
Tools used to create PR
Identify any AI code assistants used in this PR (for transparency and review context)
Related Tickets & Documents
Checklist before requesting a review
Testing