Skip to content

tool: set RHOAI index as variable in konflux_requirements.sh#1273

Merged
tisnik merged 1 commit into
lightspeed-core:mainfrom
raptorsun:update-konflux-tool
Mar 5, 2026
Merged

tool: set RHOAI index as variable in konflux_requirements.sh#1273
tisnik merged 1 commit into
lightspeed-core:mainfrom
raptorsun:update-konflux-tool

Conversation

@raptorsun

@raptorsun raptorsun commented Mar 5, 2026

Copy link
Copy Markdown
Contributor

Description

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change
  • Unit tests improvement
  • Integration tests improvement
  • End to end tests improvement
  • Benchmarks improvement

Tools used to create PR

Identify any AI code assistants used in this PR (for transparency and review context)

  • Assisted-by: (e.g., Claude, CodeRabbit, Ollama, etc., N/A if not used)
  • Generated by: (e.g., tool name and version; N/A if not used)

Related Tickets & Documents

  • Related Issue #
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

Summary by CodeRabbit

  • Chores
    • Improved build configuration by consolidating PyPI index URL references into a single configurable variable for consistent usage across pip operations.

Signed-off-by: Haoyu Sun <hasun@redhat.com>
@coderabbitai

coderabbitai Bot commented Mar 5, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 0eae108c-6d88-4464-8bca-ec658c74a714

📥 Commits

Reviewing files that changed from the base of the PR and between b57487c and 669f729.

📒 Files selected for processing (1)
  • scripts/konflux_requirements.sh

Walkthrough

Refactors scripts/konflux_requirements.sh by introducing a new public variable RHOAI_INDEX_URL set to the Red Hat PyPI index URL, and replaces all hard-coded index URL instances throughout the script with variable references for consistency.

Changes

Cohort / File(s) Summary
Variable Extraction
scripts/konflux_requirements.sh
Introduces public variable RHOAI_INDEX_URL for Red Hat PyPI index URL; replaces all hard-coded URL instances with variable references in pip compile operations, conditionals, echo statements, and hash generation steps.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly and accurately describes the main change: introducing the RHOAI_INDEX_URL variable in the konflux_requirements.sh script.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tisnik tisnik left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tisnik tisnik merged commit 196d15a into lightspeed-core:main Mar 5, 2026
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants