Skip to content

Test#1277

Closed
tisnik wants to merge 3 commits into
lightspeed-core:mainfrom
tisnik:test---
Closed

Test#1277
tisnik wants to merge 3 commits into
lightspeed-core:mainfrom
tisnik:test---

Conversation

@tisnik

@tisnik tisnik commented Mar 5, 2026

Copy link
Copy Markdown
Contributor

Description

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change
  • Unit tests improvement
  • Integration tests improvement
  • End to end tests improvement
  • Benchmarks improvement

Tools used to create PR

Identify any AI code assistants used in this PR (for transparency and review context)

  • Assisted-by: (e.g., Claude, CodeRabbit, Ollama, etc., N/A if not used)
  • Generated by: (e.g., tool name and version; N/A if not used)

Related Tickets & Documents

  • Related Issue #
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

Summary by CodeRabbit

  • Chores
    • Updated Python build dependencies and adjusted which packages are prefetched during builds.
    • Bumped build index from 3.2 to 3.3, regenerating wheel hashes and refreshing many package pins (minor version bumps and additions) for improved compatibility and integrity.

@coderabbitai

coderabbitai Bot commented Mar 5, 2026

Copy link
Copy Markdown
Contributor

Warning

Rate limit exceeded

@tisnik has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 22 minutes and 11 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a81ff4cd-3c74-4467-9637-fbc02dec9945

📥 Commits

Reviewing files that changed from the base of the PR and between cea2186 and a67c965.

📒 Files selected for processing (5)
  • .tekton/lightspeed-stack-pull-request.yaml
  • .tekton/lightspeed-stack-push.yaml
  • requirements.hashes.source.txt
  • requirements.hashes.wheel.txt
  • requirements.overrides.txt

Walkthrough

Tekton pipeline YAMLs update the prefetch Python package lists; the RHOAI wheels index is bumped from 3.2 to 3.3 and wheel hashes regenerated. requirements.overrides pins updated for a few packages and a new jiter entry added.

Changes

Cohort / File(s) Summary
Tekton Pipeline Configuration
.tekton/lightspeed-stack-pull-request.yaml, .tekton/lightspeed-stack-push.yaml
Replaced the prefetch-input binary.packages string with a different set of Python packages (removed many previous entries and added new ones such as docstring-parser, google-cloud-*, kubernetes, peft). OS/arch/py_version unchanged.
Wheel hashes index
requirements.hashes.wheel.txt
Updated RHOAI wheels index URL from 3.2 → 3.3 and regenerated the full set of wheel sha256 hashes; many hash lines changed and some package resolutions updated.
Overrides / pins
requirements.overrides.txt
Header index URL bumped to 3.3; several pinned versions updated (e.g., tokenizers 0.22.1→0.22.2, aiosqlite 0.22.0→0.22.1, cryptography 46.0.3→46.0.4, anyio 4.12.0→4.12.1, datasets 4.4.1→4.4.2, pillow 12.0.0→12.1.0) and jiter==0.12 added.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Test' is too vague and generic; it does not describe the actual changes made to the pull request, which involve updating Tekton configuration files, Python dependencies, and package hashes. Replace the title with a descriptive summary of the main changes, such as 'Update Tekton stack configurations and Python package dependencies' or similar.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
requirements.hashes.wheel.txt (1)

2-3: Update the generator script to match the 3.3 hash file.

The requirements files (lines 2–3) were regenerated against the 3.3 index, but scripts/konflux_requirements.sh still hardcodes RHOAI_INDEX_URL to 3.2. This mismatch will cause the next regeneration to drift back to 3.2.

Update line 13 of scripts/konflux_requirements.sh:

Suggested fix
-RHOAI_INDEX_URL="https://console.redhat.com/api/pypi/public-rhai/rhoai/3.2/cpu-ubi9/simple/"
+RHOAI_INDEX_URL="https://console.redhat.com/api/pypi/public-rhai/rhoai/3.3/cpu-ubi9/simple/"
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@requirements.hashes.wheel.txt` around lines 2 - 3, In
scripts/konflux_requirements.sh update the RHOAI_INDEX_URL variable (currently
pointing at the 3.2 index) to the 3.3 index used to generate
requirements.hashes.wheel.txt; replace the existing URL value with
"https://console.redhat.com/api/pypi/public-rhai/rhoai/3.3/cpu-ubi9/simple/" so
future regenerations use the same 3.3 index.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@requirements.hashes.wheel.txt`:
- Around line 2-3: In scripts/konflux_requirements.sh update the RHOAI_INDEX_URL
variable (currently pointing at the 3.2 index) to the 3.3 index used to generate
requirements.hashes.wheel.txt; replace the existing URL value with
"https://console.redhat.com/api/pypi/public-rhai/rhoai/3.3/cpu-ubi9/simple/" so
future regenerations use the same 3.3 index.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 6ef9d569-7ae5-49ad-bfbe-484b0f979e6c

📥 Commits

Reviewing files that changed from the base of the PR and between e00ec21 and c09b0d0.

📒 Files selected for processing (5)
  • .tekton/lightspeed-stack-pull-request.yaml
  • .tekton/lightspeed-stack-push.yaml
  • requirements.hashes.source.txt
  • requirements.hashes.wheel.txt
  • requirements.overrides.txt

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
.tekton/lightspeed-stack-pull-request.yaml (1)

57-57: Extract the prefetch package catalog to one source of truth.

Line 57 duplicates the same long package list in .tekton/lightspeed-stack-push.yaml Line 49. Keeping this list generated/shared from one canonical source will reduce PR/push drift and prefetch breakage during future package edits.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.tekton/lightspeed-stack-pull-request.yaml at line 57, The packages list
under the "packages" key is duplicated between
.tekton/lightspeed-stack-pull.yaml and .tekton/lightspeed-stack-push.yaml;
extract that long comma-separated package catalog into a single canonical source
(e.g., a shared YAML fragment or a separate .tekton/package-list.yaml or a
Tekton params/ConfigMap referenced by both tasks) and update both files to
reference that single source instead of inlining the list; specifically, replace
the inline "packages" value in .tekton/lightspeed-stack-pull.yaml and
.tekton/lightspeed-stack-push.yaml with a reference to the canonical resource
(or a common YAML anchor) so updates only need to be made in one place.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In @.tekton/lightspeed-stack-pull-request.yaml:
- Line 57: The packages list under the "packages" key is duplicated between
.tekton/lightspeed-stack-pull.yaml and .tekton/lightspeed-stack-push.yaml;
extract that long comma-separated package catalog into a single canonical source
(e.g., a shared YAML fragment or a separate .tekton/package-list.yaml or a
Tekton params/ConfigMap referenced by both tasks) and update both files to
reference that single source instead of inlining the list; specifically, replace
the inline "packages" value in .tekton/lightspeed-stack-pull.yaml and
.tekton/lightspeed-stack-push.yaml with a reference to the canonical resource
(or a common YAML anchor) so updates only need to be made in one place.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 083ebc9c-37de-4df6-a843-9f6f84f92723

📥 Commits

Reviewing files that changed from the base of the PR and between c09b0d0 and cea2186.

📒 Files selected for processing (5)
  • .tekton/lightspeed-stack-pull-request.yaml
  • .tekton/lightspeed-stack-push.yaml
  • requirements.hashes.source.txt
  • requirements.hashes.wheel.txt
  • requirements.overrides.txt

@tisnik tisnik closed this Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant