Skip to content

LCORE-1437: Enable linter rule B010 #1297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tisnik merged 3 commits into from
Mar 10, 2026
Merged

LCORE-1437: Enable linter rule B010 #1297

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
798e469
Added linter rule B009
tisnik Mar 10, 2026
902320e
Refactored sources
tisnik Mar 10, 2026
3f1c3c9
Better approach
tisnik Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ disable = ["R0801"]
extend-exclude = ["tests/profiles/syntax_error.py"]

[tool.ruff.lint]
extend-select = ["TID251", "UP006", "UP007", "UP017", "UP035", "RUF100", "B010"]
extend-select = ["TID251", "UP006", "UP007", "UP017", "UP035", "RUF100", "B009", "B010"]

[tool.ruff.lint.flake8-tidy-imports.banned-api]
unittest = { msg = "use pytest instead of unittest" }
Expand Down
4 changes: 2 additions & 2 deletions src/app/endpoints/streaming_query.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -698,7 +698,7 @@ async def response_generator( # pylint: disable=too-many-branches,too-many-stat
# Completed response - capture final text and response object
elif event_type == "response.completed":
latest_response_object = cast(
OpenAIResponseObject, getattr(chunk, "response")
OpenAIResponseObject, getattr(chunk, "response") # noqa: B009
)
turn_summary.llm_response = turn_summary.llm_response or "".join(text_parts)
yield stream_event(
Expand All @@ -714,7 +714,7 @@ async def response_generator( # pylint: disable=too-many-branches,too-many-stat
# Incomplete or failed response - emit error
elif event_type in ("response.incomplete", "response.failed"):
latest_response_object = cast(
OpenAIResponseObject, getattr(chunk, "response")
OpenAIResponseObject, getattr(chunk, "response") # noqa: B009
)
error_message = (
latest_response_object.error.message
Expand Down
Loading