Skip to content

LCORE-1438: removed leftovers#1348

Merged
tisnik merged 1 commit into
lightspeed-core:mainfrom
tisnik:lcore-1438-removed-leftovers
Mar 18, 2026
Merged

LCORE-1438: removed leftovers#1348
tisnik merged 1 commit into
lightspeed-core:mainfrom
tisnik:lcore-1438-removed-leftovers

Conversation

@tisnik

@tisnik tisnik commented Mar 18, 2026

Copy link
Copy Markdown
Contributor

Description

LCORE-1438: removed leftovers

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change
  • Unit tests improvement
  • Integration tests improvement
  • End to end tests improvement
  • Benchmarks improvement

Tools used to create PR

  • Assisted-by: N/A
  • Generated by: N/A

Related Tickets & Documents

  • Related Issue #LCORE-1438

Summary by CodeRabbit

  • Chores

    • Simplified build configuration by removing version variable and automated requirements generation.
  • Documentation

    • Updated build system documentation to reflect current targets and configuration changes.

@coderabbitai

coderabbitai Bot commented Mar 18, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 3f75e5f0-f462-44e7-bd72-848df26133fe

📥 Commits

Reviewing files that changed from the base of the PR and between c6a2205 and 0e953eb.

📒 Files selected for processing (2)
  • Makefile
  • README.md
💤 Files with no reviewable changes (1)
  • Makefile

Walkthrough

The PR removes the TORCH_VERSION variable and requirements.txt target from the Makefile, updating the README documentation to reflect these removals while reorganizing help target references.

Changes

Cohort / File(s) Summary
Build Configuration Cleanup
Makefile
Removed public variable TORCH_VERSION and the requirements.txt target along with its associated command for exporting Python requirements.
Documentation Updates
README.md
Updated Makefile targets documentation to remove requirements.txt target reference, restore help target entry, and reorganize konflux-rpm-lock target formatting.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'LCORE-1438: removed leftovers' is vague and generic, using non-descriptive language that doesn't clearly convey the specific changes made to the codebase. Replace vague terms with specific details about what was removed (e.g., 'LCORE-1438: remove TORCH_VERSION variable and requirements.txt target from Makefile').
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tisnik tisnik merged commit cdec708 into lightspeed-core:main Mar 18, 2026
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant