Skip to content

LCORE-1273: Replaced HTTP status code#1376

Merged
tisnik merged 1 commit into
lightspeed-core:mainfrom
tisnik:lcore-1273-replaced-http-status-code
Mar 23, 2026
Merged

LCORE-1273: Replaced HTTP status code#1376
tisnik merged 1 commit into
lightspeed-core:mainfrom
tisnik:lcore-1273-replaced-http-status-code

Conversation

@tisnik

@tisnik tisnik commented Mar 23, 2026

Copy link
Copy Markdown
Contributor

Description

LCORE-1273: Replaced HTTP status code

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change
  • Unit tests improvement
  • Integration tests improvement
  • End to end tests improvement
  • Benchmarks improvement

Tools used to create PR

  • Assisted-by: N/A
  • Generated by: N/A

Related Tickets & Documents

  • Related Issue #LCORE-1273

Summary by CodeRabbit

  • Bug Fixes
    • Updated HTTP error response code for when users submit prompts or content that exceed size limits.

@coderabbitai

coderabbitai Bot commented Mar 23, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: ce53689e-0649-4950-8b5b-f7d87a357d53

📥 Commits

Reviewing files that changed from the base of the PR and between bb1301f and ecd993a.

📒 Files selected for processing (2)
  • src/models/responses.py
  • tests/unit/models/responses/test_error_responses.py

Walkthrough

Updated HTTP status code in PromptTooLongResponse from HTTP_413_REQUEST_ENTITY_TOO_LARGE to HTTP_413_CONTENT_TOO_LARGE, with corresponding test assertion update to reflect the new constant value.

Changes

Cohort / File(s) Summary
Status Code Update
src/models/responses.py, tests/unit/models/responses/test_error_responses.py
Changed HTTP status code constant from HTTP_413_REQUEST_ENTITY_TOO_LARGE to HTTP_413_CONTENT_TOO_LARGE in the PromptTooLongResponse class and updated the corresponding test assertion to validate the new status code value.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'LCORE-1273: Replaced HTTP status code' is vague and doesn't specify which status code was replaced or why, making it unclear what the primary change accomplishes. Provide a more specific title that indicates the actual change, such as 'LCORE-1273: Replace HTTP 413 status code from REQUEST_ENTITY_TOO_LARGE to CONTENT_TOO_LARGE' for clarity.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tisnik tisnik merged commit 9081099 into lightspeed-core:main Mar 23, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant