Skip to content

LCORE-1449: Fixed types in vector-io#1402

Merged
tisnik merged 1 commit into
lightspeed-core:mainfrom
tisnik:fixed-types-in-vector-io
Mar 25, 2026
Merged

LCORE-1449: Fixed types in vector-io#1402
tisnik merged 1 commit into
lightspeed-core:mainfrom
tisnik:fixed-types-in-vector-io

Conversation

@tisnik

@tisnik tisnik commented Mar 25, 2026

Copy link
Copy Markdown
Contributor

Description

LCORE-1449: Fixed types in vector-io

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change
  • Unit tests improvement
  • Integration tests improvement
  • End to end tests improvement
  • Benchmarks improvement

Tools used to create PR

  • Assisted-by: N/A
  • Generated by: N/A

Related Tickets & Documents

  • Related Issue #LCORE-1449

Summary by CodeRabbit

  • Bug Fixes
    • Fixed vector search parameter handling to properly process all Solr filter configurations, including edge cases previously missed.

@tisnik tisnik requested a review from are-ces March 25, 2026 10:46
@tisnik tisnik force-pushed the fixed-types-in-vector-io branch from b8410be to 9fa4264 Compare March 25, 2026 10:47
@coderabbitai

coderabbitai Bot commented Mar 25, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 5fdce4de-6ad7-4a10-b053-7c346bd8f7eb

📥 Commits

Reviewing files that changed from the base of the PR and between a9a7c6e and 9fa4264.

📒 Files selected for processing (1)
  • src/utils/vector_search.py

Walkthrough

Updated _build_query_params function in vector_search.py with explicit type annotation for params variable and modified the Solr filter conditional to use is not None check instead of truthiness evaluation, allowing empty dictionaries to be properly included.

Changes

Cohort / File(s) Summary
Type annotation and conditional logic fix
src/utils/vector_search.py
Added explicit dict[str, Any] type annotation to params variable. Changed if solr: to if solr is not None: to properly handle empty Solr dictionaries that were previously skipped due to falsy evaluation.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly indicates the main change—fixing types in vector-io—and directly relates to the changeset which updates type annotations in the vector_search.py module.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@are-ces

are-ces commented Mar 25, 2026

Copy link
Copy Markdown
Contributor

LGTM TY

@tisnik tisnik merged commit 4b74ef4 into lightspeed-core:main Mar 25, 2026
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants