Skip to content

RHOKP-1361: enable deep-linking using correct online and offline…#1770

Merged
are-ces merged 1 commit into
lightspeed-core:mainfrom
Jared-Sprague:RHOKP-1361-okp-rag-deep-links
May 20, 2026
Merged

RHOKP-1361: enable deep-linking using correct online and offline…#1770
are-ces merged 1 commit into
lightspeed-core:mainfrom
Jared-Sprague:RHOKP-1361-okp-rag-deep-links

Conversation

@Jared-Sprague
Copy link
Copy Markdown
Contributor

… solr meta-data fields for urls

This updates the Solr reference URL mappings to use the correct solr url fields for both online and offline modes. Previously doc_id was used as the offline reference url. That was not correct, the correct offline url field is called source_path

Type of change

  • [ x] Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change
  • Unit tests improvement
  • Integration tests improvement
  • End to end tests improvement
  • Benchmarks improvement

Tools used to create PR

  • Assisted-by: Claude

Related Tickets & Documents

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  1. Test OKP rag reference urls in both online and offline mode

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 19, 2026

Warning

Rate limit exceeded

@Jared-Sprague has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 43 minutes and 30 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: cb25182e-8bca-439a-b010-1ec1302ecb7c

📥 Commits

Reviewing files that changed from the base of the PR and between 58ad890 and 4e295c2.

📒 Files selected for processing (3)
  • src/llama_stack_configuration.py
  • src/utils/vector_search.py
  • tests/unit/utils/test_vector_search.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
✨ Simplify code
  • Create PR with simplified code

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tisnik tisnik changed the title feat: RHOKP-1361 enable deep-linking using correct online and offline… RHOKP-1361: enable deep-linking using correct online and offline… May 19, 2026
Copy link
Copy Markdown
Contributor

@tisnik tisnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tisnik tisnik requested a review from are-ces May 19, 2026 18:08
Copy link
Copy Markdown
Contributor

@are-ces are-ces left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY Jared LGTM

@are-ces are-ces merged commit 6a0664d into lightspeed-core:main May 20, 2026
29 of 31 checks passed
asimurka pushed a commit to asimurka/lightspeed-stack that referenced this pull request May 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants