LCORE-2504: Added missing unit test

[tisnik]

Description

LCORE-2504: Added missing unit test

Type of change

• Refactor
• New feature
• Bug fix
• CVE fix
• Optimization
• Documentation Update
• Configuration Update
• Bump-up service version
• Bump-up dependent library
• Bump-up library or tool used for development (does not change the final image)
• CI configuration change
• Konflux configuration change
• Unit tests improvement
• Integration tests improvement
• End to end tests improvement
• Benchmarks improvement

Tools used to create PR

• Assisted-by: N/A
• Generated by: N/A

Related Tickets & Documents

• Related Issue #LCORE-2504

Summary by CodeRabbit

• Tests
  • Added test coverage for configuration dumping with specific compaction parameters.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 9b5799e7-1fae-483b-b4e5-b92b0c40c2bb

📥 Commits

Reviewing files that changed from the base of the PR and between 2a71a89 and 83cb012.

📒 Files selected for processing (1)

• tests/unit/models/config/test_dump_configuration.py

📜 Recent review details

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (16)

• GitHub Check: unit_tests (3.13)
• GitHub Check: build-pr
• GitHub Check: Pylinter
• GitHub Check: Pyright
• GitHub Check: mypy
• GitHub Check: list_outdated_dependencies
• GitHub Check: integration_tests (3.12)
• GitHub Check: integration_tests (3.13)
• GitHub Check: Konflux kflux-prd-rh02 / lightspeed-stack-on-pull-request
• GitHub Check: E2E Tests for Lightspeed Evaluation job
• GitHub Check: E2E: library mode / ci / group 1
• GitHub Check: E2E: library mode / ci / group 3
• GitHub Check: E2E: server mode / ci / group 3
• GitHub Check: E2E: server mode / ci / group 1
• GitHub Check: E2E: server mode / ci / group 2
• GitHub Check: E2E: library mode / ci / group 2

🧰 Additional context used

📓 Path-based instructions (1)

tests/**/*.py

📄 CodeRabbit inference engine (AGENTS.md)

tests/**/*.py: Use pytest for all unit and integration tests; do not use unittest
Use pytest.mark.asyncio marker for async tests

Files:

• tests/unit/models/config/test_dump_configuration.py

🔇 Additional comments (2)

tests/unit/models/config/test_dump_configuration.py (2)

15-15: LGTM!

---

2309-2531: LGTM!

---

Walkthrough

The test module now imports CompactionConfiguration and adds a new unit test that constructs a Configuration object with custom compaction settings, dumps it to JSON, and verifies the resulting JSON contains the expected compaction section with all provided override values.

Changes

Configuration Compaction Test

Layer / File(s)	Summary
Compaction configuration dump test tests/unit/models/config/test_dump_configuration.py	Adds import of CompactionConfiguration and new test test_dump_configuration_specific_compaction_values that validates a Configuration with explicit compaction parameters (enabled, threshold ratio, token floor, buffer settings) serializes correctly to JSON with those values preserved.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'LCORE-2504: Added missing unit test' is related to the changeset, which adds a new unit test for configuration dumping with compaction values.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

✨ Simplify code

• Create PR with simplified code

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[tisnik]

/retest