Skip to content

LCORE-2310: Adding explicit TLS output checks#1869

Merged
tisnik merged 1 commit into
lightspeed-core:mainfrom
asimurka:pydantic-ai_konflux_deps
Jun 8, 2026
Merged

LCORE-2310: Adding explicit TLS output checks#1869
tisnik merged 1 commit into
lightspeed-core:mainfrom
asimurka:pydantic-ai_konflux_deps

Conversation

@asimurka

@asimurka asimurka commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Description

Fixes bug in tls e2e mock server that was previously returning empty response. This was not previously caught by e2e tests. This PR adds explicit check for the LLM response.

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change
  • Unit tests improvement
  • Integration tests improvement
  • End to end tests improvement
  • Benchmarks improvement

Tools used to create PR

Identify any AI code assistants used in this PR (for transparency and review context)

  • Assisted-by: Cursor

Related Tickets & Documents

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

Summary by CodeRabbit

  • Tests
    • Enhanced TLS end-to-end test scenarios to validate successful response content across TLS verification configurations, including CA certificate verification, mutual TLS authentication, and TLSv1.3 minimum version validation.

@asimurka asimurka marked this pull request as draft June 8, 2026 08:17
@coderabbitai

coderabbitai Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

Adds SSE stream support and a shared response text in the mock TLS inference server; updates four TLS end-to-end test success scenarios to assert responses contain the mock server greeting "Hello from the TLS mock inference server".

Changes

TLS E2E Response Body Validation

Layer / File(s) Summary
Mock TLS inference server: streaming and shared response text
tests/e2e/mock_tls_inference_server/server.py
Adds shared completion_id/response_text, supports stream=true by emitting SSE chat.completion.chunk events and [DONE], and uses response_text for non-stream replies.
Response body assertions in TLS success scenarios
tests/e2e/features/tls.feature
Four TLS success scenarios (TLS verification disabled, CA cert verification, mutual TLS auth, TLS minimum version TLSv1.3) now assert the HTTP 200 response body contains "Hello from the TLS mock inference server".

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'LCORE-2310: Adding explicit TLS output checks' clearly summarizes the main changes: adding explicit assertions for TLS output in the e2e tests and supporting streaming responses in the mock TLS inference server.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
✨ Simplify code
  • Create PR with simplified code

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@asimurka asimurka force-pushed the pydantic-ai_konflux_deps branch from 2bb9d5f to 76ed710 Compare June 8, 2026 09:22
@asimurka asimurka force-pushed the pydantic-ai_konflux_deps branch from 76ed710 to b1fbacd Compare June 8, 2026 10:09
@asimurka asimurka marked this pull request as ready for review June 8, 2026 10:09
@asimurka asimurka requested a review from jrobertboos June 8, 2026 10:10
@asimurka asimurka changed the title LCORE-: Adding explicit TLS output checks LCORE-2310: Adding explicit TLS output checks Jun 8, 2026
@asimurka asimurka requested a review from tisnik June 8, 2026 10:42

@tisnik tisnik left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrobertboos jrobertboos left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tisnik tisnik merged commit d464fbc into lightspeed-core:main Jun 8, 2026
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants