LCORE- Fold and strip tag value in build_image step#1924
Conversation
The tags field expects a space separated list of values. Preserving new lines with the block syntax is incorrect. Also strip newlines from the end.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📜 Recent review details⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
🧰 Additional context used🧠 Learnings (1)📚 Learning: 2026-05-06T08:35:54.687ZApplied to files:
🔇 Additional comments (1)
WalkthroughA GitHub Actions workflow is modified to adjust how the tag string passed to the Buildah container build action is formatted. The change switches YAML block scalar syntax from literal ( ChangesBuild and push release workflow YAML adjustment
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Description
The tags field expects a space separated list of values. Preserving new lines with the block syntax appears to work but is incorrect. Also strip newlines from the end.
This isn't strictly necessary but it does correct the log output.
Without this change (using a testing tag of 0.5.10):
With this change:
Type of change
Tools used to create PR
Just me
Related Tickets & Documents
None
Checklist before requesting a review
Testing
I ran tests in my fork by pushing several tags to trigger the workflow.
Summary by CodeRabbit
No user-facing changes in this release.