Skip to content

LCORE- Fold and strip tag value in build_image step#1924

Merged
tisnik merged 1 commit into
lightspeed-core:mainfrom
samdoran:fold-em
Jun 12, 2026
Merged

LCORE- Fold and strip tag value in build_image step#1924
tisnik merged 1 commit into
lightspeed-core:mainfrom
samdoran:fold-em

Conversation

@samdoran

@samdoran samdoran commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Description

The tags field expects a space separated list of values. Preserving new lines with the block syntax appears to work but is incorrect. Also strip newlines from the end.

This isn't strictly necessary but it does correct the log output.

Without this change (using a testing tag of 0.5.10):

Run redhat-actions/buildah-build@v2
  with:
    image: lightspeed-stack
    tags: 0.5.10
  latest
  
    containerfiles: deploy/lightspeed-stack/Containerfile
  
    archs: amd64, arm64
    oci: true
    context: .
    tls-verify: true

With this change:

Run redhat-actions/buildah-build@v2
  with:
    image: lightspeed-stack
    tags: 0.5.10 latest
    containerfiles: deploy/lightspeed-stack/hack
  
    archs: amd64, arm64
    oci: true
    context: .
    tls-verify: true

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change
  • Unit tests improvement
  • Integration tests improvement
  • End to end tests improvement
  • Benchmarks improvement

Tools used to create PR

Just me

Related Tickets & Documents

None

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

I ran tests in my fork by pushing several tags to trigger the workflow.

Summary by CodeRabbit

  • Chores
    • Updated internal build workflow configuration to improve tag handling during release processes.

No user-facing changes in this release.

The tags field expects a space separated list of values. Preserving new lines
with the block syntax is incorrect. Also strip newlines from the end.
@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 81961883-fe0e-4ed9-bfca-8acf754fd640

📥 Commits

Reviewing files that changed from the base of the PR and between dd69d32 and d7ca4f8.

📒 Files selected for processing (1)
  • .github/workflows/build_and_push_release.yaml
📜 Recent review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: build-pr
  • GitHub Check: bandit
  • GitHub Check: Pylinter
  • GitHub Check: check_dependencies
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2026-05-06T08:35:54.687Z
Learnt from: radofuchs
Repo: lightspeed-core/lightspeed-stack PR: 1690
File: .github/workflows/e2e_tests_providers.yaml:279-285
Timestamp: 2026-05-06T08:35:54.687Z
Learning: In .github/workflows/e2e_tests_providers.yaml and related e2e workflow files, the show_logs step should not use docker compose logs with --tail or --since (i.e., keep logs unbounded). The quick connectivity test runs once immediately after container startup, so the log output is small and a log tail limit is unnecessary. If you adjust this, add a rationale comment in the workflow explaining why unbounded logs are acceptable and ensure CI behavior remains deterministic.

Applied to files:

  • .github/workflows/build_and_push_release.yaml
🔇 Additional comments (1)
.github/workflows/build_and_push_release.yaml (1)

44-47: LGTM!


Walkthrough

A GitHub Actions workflow is modified to adjust how the tag string passed to the Buildah container build action is formatted. The change switches YAML block scalar syntax from literal (|) to folded (>-), affecting newline handling in the multiline tag value.

Changes

Build and push release workflow YAML adjustment

Layer / File(s) Summary
Buildah tags block scalar format
.github/workflows/build_and_push_release.yaml
The tags input to redhat-actions/buildah-build@v2 changes from literal block scalar (|) to folded block scalar (>-), which folds newlines into spaces and strips the trailing newline from the computed tag list string containing ${{ env.GIT_TAG }} and conditional latest tag.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly describes the main change: converting a YAML block scalar from literal to folded format to properly format the tags value in the build_image step.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
✨ Simplify code
  • Create PR with simplified code

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tisnik tisnik left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tisnik tisnik merged commit 7a44438 into lightspeed-core:main Jun 12, 2026
28 of 29 checks passed
@samdoran samdoran deleted the fold-em branch June 12, 2026 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants