Skip to content

LCORE-2248: LCORE version stored on only one place #1935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tisnik merged 1 commit into from
Jun 16, 2026
Merged

LCORE-2248: LCORE version stored on only one place #1935

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tests/benchmarks/data/python_10000_lines.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1967,7 +1967,7 @@ def test_score_multiplier_mapping_not_loaded() -> None:
"embedding_dimension": 619,
"vector_db_id": "Learn computer positive nor yet notice.",
"db_path": "Sort rule soldier relationship. Wife front kid cit",
"score_multiplier": 310.63,
"score_multiplier": 319.63,
},
{
"rag_id": "Question to front often.",
Expand Down Expand Up @@ -5819,7 +5819,7 @@ def test_2_score_multiplier_mapping_not_loaded() -> None:
"embedding_dimension": 619,
"vector_db_id": "Learn computer positive nor yet notice.",
"db_path": "Sort rule soldier relationship. Wife front kid cit",
"score_multiplier": 310.63,
"score_multiplier": 319.63,
},
{
"rag_id": "Question to front often.",
Expand Down Expand Up @@ -9671,7 +9671,7 @@ def test_3_score_multiplier_mapping_not_loaded() -> None:
"embedding_dimension": 619,
"vector_db_id": "Learn computer positive nor yet notice.",
"db_path": "Sort rule soldier relationship. Wife front kid cit",
"score_multiplier": 310.63,
"score_multiplier": 319.63,
},
{
"rag_id": "Question to front often.",
Expand Down
2 changes: 1 addition & 1 deletion tests/integration/endpoints/test_rlsapi_v1_integration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ def _create_mock_request(mocker: MockerFixture) -> Any:
mock_request = mocker.Mock()
# Use spec=[] to create a Mock with no attributes, simulating absent rh_identity_data
mock_request.state = mocker.Mock(spec=[])
mock_request.headers = {"User-Agent": "CLA/0.6.0rc2"}
mock_request.headers = {"User-Agent": f"CLA/{__version__}"}
return mock_request


Expand Down
4 changes: 3 additions & 1 deletion tests/unit/app/endpoints/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
import pytest
from pytest_mock import MockerFixture

from version import __version__


@pytest.fixture(name="mock_request_factory")
def mock_request_factory_fixture(mocker: MockerFixture) -> Callable[..., Any]:
Expand All @@ -17,7 +19,7 @@ def mock_request_factory_fixture(mocker: MockerFixture) -> Callable[..., Any]:

def _create(rh_identity: Any = None) -> Any:
mock_request = mocker.Mock()
mock_request.headers = {"User-Agent": "CLA/0.6.0rc2"}
mock_request.headers = {"User-Agent": f"CLA/{__version__}"}

if rh_identity is not None:
mock_request.state = mocker.Mock()
Expand Down
5 changes: 3 additions & 2 deletions tests/unit/observability/formats/test_rlsapi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
from pytest_mock import MockerFixture

from observability.formats.rlsapi import InferenceEventData, build_inference_event
from version import __version__


@pytest.fixture(name="sample_event_data")
Expand All @@ -17,7 +18,7 @@ def sample_event_data_fixture() -> InferenceEventData:
org_id="12345678",
system_id="abc-def-123",
request_id="req_xyz789",
cla_version="CLA/0.6.0rc2",
cla_version=f"CLA/{__version__}",
system_os="RHEL",
system_version="9.3",
system_arch="x86_64",
Expand All @@ -40,7 +41,7 @@ def test_builds_event_with_all_fields(
assert event["org_id"] == "12345678"
assert event["system_id"] == "abc-def-123"
assert event["request_id"] == "req_xyz789"
assert event["cla_version"] == "CLA/0.6.0rc2"
assert event["cla_version"] == f"CLA/{__version__}"
assert event["system_os"] == "RHEL"
assert event["system_version"] == "9.3"
assert event["system_arch"] == "x86_64"
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/test_configuration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2010,7 +2010,7 @@ def test_score_multiplier_mapping_not_loaded() -> None:
"embedding_dimension": 619,
"vector_db_id": "Learn computer positive nor yet notice.",
"db_path": "Sort rule soldier relationship. Wife front kid cit",
"score_multiplier": 310.63,
"score_multiplier": 319.63,
},
{
"rag_id": "Question to front often.",
Expand Down
Loading