Skip to content

LCORE-2076: Fix missing skills argument in streaming agent build #1945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tisnik merged 1 commit into from
Jun 18, 2026
+10 −1
Merged

LCORE-2076: Fix missing skills argument in streaming agent build #1945

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/utils/agents/streaming.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ async def retrieve_agent_response_generator(
turn_summary,
)

agent = build_agent(context.client, responses_params)
agent = build_agent(context.client, responses_params, configuration.skills)

return (
agent_response_generator(
Expand Down
9 changes: 9 additions & 0 deletions tests/unit/utils/agents/test_streaming.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,14 @@ def patch_recording_metrics_fixture(mocker: MockerFixture) -> None:
mocker.patch("utils.agents.query.recording.record_llm_call")


@pytest.fixture(name="patch_streaming_configuration")
def patch_streaming_configuration_fixture(mocker: MockerFixture) -> None:
"""Patch streaming module configuration for isolated agent streaming tests."""
mock_config = mocker.MagicMock()
mock_config.skills = None
mocker.patch("utils.agents.streaming.configuration", mock_config)


@pytest.fixture(autouse=True, name="stream_interrupt_mocks")
def stream_interrupt_mocks_fixture(mocker: MockerFixture) -> dict[str, Any]:
"""Patch stream interrupt registry and deregister for wrapper tests."""
Expand Down Expand Up @@ -479,6 +487,7 @@ def test_part_end_native_tool_call_returns_none_when_skipped(
assert not turn_state.turn_summary.tool_calls


@pytest.mark.usefixtures("patch_streaming_configuration")
class TestRetrieveAgentResponseGenerator:
"""Tests for retrieve_agent_response_generator."""

Expand Down
Loading