LCORE-3323: Fixed QuestionValidity Shield - #2275
Open
jrobertboos wants to merge 1 commit into
Open
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
QuestionValidityshield capability short-circuited rejected user turns without ever recording them in conversation history — when a question was blocked as off-topic, the rejection message was returned to the caller but the turn (user question + refusal) never made it into the underlying Llama Stack/OGX conversation. This left conversation history incomplete for rejected turns, which is misleading for later inspection/auditing and breaks continuity for follow-up turns that rely on history.This fix pulls the active Llama Stack conversation ID out of the agent's model settings (
extra_body.conversation) when a question is rejected, and persists the rejected turn (user message + the configuredinvalid_question_response) to that conversation viaappend_turn_to_conversation. It also seeds the in-memoryGraphAgentState.message_historywith the same user/response pair so the rejected turn is reflected consistently in both the persisted conversation and the local agent state. If no conversation ID can be determined (e.g. capability used outside a Llama Stack-backed agent), persistence is skipped and a warning is logged instead of raising.Type of change
Tools used to create PR
Related Tickets & Documents
Checklist before requesting a review
Testing
tests/unit/pydantic_ai_lightspeed/capabilities/question_validity/test_capability.py:TestExtractConversationId: covers extracting the conversation ID from model settings, including missing settings, missingextra_body, non-dictextra_body, and non-string conversation values.TestWrapRun: new cases verifying that a rejected question persists the turn to the conversation, that persistence is skipped (without crashing) when no conversation ID is available, and that an allowed question never triggers persistence.