Change %q in logs and errors to %#q [Part3]#5029
Open
mie313 wants to merge 1 commit into
Open
Conversation
mie313
force-pushed
the
use_hashq_part3
branch
3 times, most recently
from
99fdc19 to
98548d5
Compare
jandubois
reviewed
May 25, 2026
| homedir := u.Homedir | ||
| if homedir == "" { | ||
| return fmt.Errorf("homedir is required for user %q", u.Name) | ||
| return fmt.Errorf("homedir is required for user %#qq", u.Name) |
Member
There was a problem hiding this comment.
You have again included a couple of %#qq instances in the PR. How do they happen? Did you create this with AI without checking the output?
Contributor
Author
There was a problem hiding this comment.
Apologies for the inconvenience, but I have never used AI at all for contributing lima.
Since I modified all codes at once and then divided them into a few PRs, typos the same as before might remain.
I will make sure to double-check not to contain any typos before turning a PR ready for review.
Contributor
Author
There was a problem hiding this comment.
Fixed all typos and squashed 🙏
Signed-off-by: mie313 <mie313.tanaka@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change %q in logs and errors to %#q and update the codes so that backticks are used everywhere in logs and errors. (all files in the following directories) .
pkg/guestagentpkg/guestpatchpkg/hostagentpkg/httpclientutilpkg/identifierspkg/imgutilpkg/instancepkg/iso9660utilpkg/limactlutilpkg/limainfopkg/limatmplpkg/limatypeRelated issue: #4898
This PR is a continuation of the work from #4909 and #5017 .