Merge remote-tracking branch 'upstream/master' into stable

Author: ibuclaw

.azure-pipelines/windows.sh

@@ -72,9 +72,8 @@ if [[ "$HOST_DMD_VERSION" == "2.079.0" ]]; then
 fi
 
 cd "$DMD_DIR"
-"$HOST_DC" -m$MODEL compiler/src/build.d -ofgenerated/build.exe
-generated/build.exe -j$N MODEL=$MODEL HOST_DMD=$HOST_DC BUILD=debug "${disable_debug_for_unittests[@]}" unittest
-generated/build.exe -j$N MODEL=$MODEL HOST_DMD=$HOST_DC DFLAGS="-L-LARGEADDRESSAWARE" ENABLE_RELEASE=1 ENABLE_ASSERTS=1 dmd
+"$GNU_MAKE" -j$N MODEL=$MODEL HOST_DMD=$HOST_DC BUILD=debug "${disable_debug_for_unittests[@]}" dmd-unittest
+"$GNU_MAKE" -j$N MODEL=$MODEL HOST_DMD=$HOST_DC HOST_DFLAGS="-L-LARGEADDRESSAWARE" ENABLE_RELEASE=1 ENABLE_ASSERTS=1 dmd
 
 DMD_BIN_PATH="$DMD_DIR/generated/windows/release/$MODEL/dmd.exe"
 
@@ -94,11 +93,9 @@ cd "$DMD_DIR/compiler/test"
 
 # Rebuild dmd with ENABLE_COVERAGE for coverage tests
 if [ "${DMD_TEST_COVERAGE:-0}" = "1" ] ; then
-
     # Recompile debug dmd + unittests
     rm -rf "$DMD_DIR/generated/windows"
-    ../../generated/build.exe -j$N MODEL=$MODEL DFLAGS="-L-LARGEADDRESSAWARE" ENABLE_DEBUG=1 ENABLE_COVERAGE=1 dmd
-    ../../generated/build.exe -j$N MODEL=$MODEL DFLAGS="-L-LARGEADDRESSAWARE" ENABLE_DEBUG=1 ENABLE_COVERAGE=1 unittest
+    "$GNU_MAKE" -j$N -C "$DMD_DIR" MODEL=$MODEL HOST_DMD=$HOST_DC HOST_DFLAGS="-L-LARGEADDRESSAWARE" ENABLE_DEBUG=1 ENABLE_COVERAGE=1 dmd dmd-unittest
 fi
 
 "$HOST_DC" -m$MODEL -g -i run.d

.circleci/config.yml

@@ -6,7 +6,8 @@ jobs:
       - image: cimg/base:current-20.04
     parallelism: 1
     steps:
-      - checkout
+      - checkout:
+          method: blobless
       - run:
           command: ./.circleci/run.sh install-deps
           name: Install dependencies

.github/workflows/release.yml

@@ -0,0 +1,90 @@
+# GitHub Action to build releases on command
+#
+# This script builds and packages a release for Linux, Windows, OSX and FreeBSD
+# using the stable branch. The generated archives are published as a release
+# on the GitHub release page.
+#
+# Job overview:
+# 1. Builds the actual release using `build_release_template` from dlang/installer
+# 2. Publishes all artifacts from (1) to the release page on GitHub
+#
+# Triggered manually by authorized users via workflow_dispatch.
+
+name: build-release
+
+on:
+  workflow_dispatch:
+    inputs:
+      branch:
+        description: 'Branch to build from'
+        required: true
+        type: string
+        default: stable
+      tag:
+        description: 'Release tag (e.g., v2.109.0)'
+        required: true
+        type: string
+      prerelease:
+        description: 'Mark as pre-release'
+        required: false
+        type: boolean
+        default: false
+
+jobs:
+  # Build and package a new release for all supported platforms
+  build-all-releases:
+    name: Build release from ${{ github.event.inputs.branch }}
+    uses: dlang/installer/.github/workflows/build_release_template.yml@master
+    with:
+      release_branch: ${{ github.event.inputs.branch }}
+
+  # Bundles and publishes the entire release
+  generate_release:
+    name: "Publish artifacts on the release page"
+    needs:
+      - build-all-releases
+    runs-on: ubuntu-latest
+
+    steps:
+      #################################################################
+      # Fetch all artifacts from the jobs defined above
+      #
+      - name: Download generated releases from the artifacts
+        uses: actions/download-artifact@v4
+        with:
+          pattern: dmd-release-*
+          merge-multiple: true
+          path: ~/artifacts/
+
+      #################################################################
+      # Debug: Check that all required artifacts are present
+      #
+      - name: Display all files included in the artifacts
+        id: list-artifacts
+        shell: bash
+        run: |
+          set -euox pipefail
+          ls -aul ~ ~/artifacts
+          echo "artifacts_directory=$HOME/artifacts" >> $GITHUB_OUTPUT
+
+      #################################################################
+      # Create the new release using the downloaded artifacts
+      #
+      - name: Create the release
+        uses: ncipollo/release-action@v1
+        with:
+          token: "${{ secrets.GITHUB_TOKEN }}"
+          name: DMD ${{ github.event.inputs.tag }}
+          prerelease: ${{ github.event.inputs.prerelease }}
+          body: |
+            Release of the reference D compiler
+
+            | Component | Revision                                                         |
+            | --------- | ---------------------------------------------------------------- |
+            | DMD       | dlang/dmd@${{ needs.build-all-releases.outputs.dmd-revision }}           |
+            | Phobos    | dlang/phobos@${{ needs.build-all-releases.outputs.phobos-revision }}     |
+
+          artifacts: ${{ steps.list-artifacts.outputs.artifacts_directory }}/*
+          artifactErrorsFailBuild: true
+          tag: ${{ github.event.inputs.tag }}
+          commit: ${{ needs.build-all-releases.outputs.dmd-revision }}

.github/workflows/runnable_cxx.yml

@@ -193,11 +193,13 @@ jobs:
     - name: Build compiler & standard library
       run: |
         set -eux
+        extraFlags=()
         if [[ '${{ matrix.os }}' == macos-14 ]]; then
-          # don't try compiling a native arm64 DMD on macOS (doesn't work)
-          make -C dmd  -j$N dmd DFLAGS="-mtriple=x86_64-apple-macos14"
+          # DMD doesn't work on arm64 yet. Make LDC host compiler cross-compile
+          # DMD to x86_64, and then use implicit Rosetta emulation.
+          extraFlags=(HOST_DFLAGS="-mtriple=x86_64-apple-macos14")
         fi
-        make -C dmd    -j$N
+        make -C dmd    -j$N "${extraFlags[@]}"
         make -C phobos -j$N
 
     ########################################
@@ -213,10 +215,8 @@ jobs:
       if: runner.os != 'Windows' # not supported by build.d yet
       run: |
         set -eux
+        extraFlags=()
         if [[ '${{ matrix.os }}' == macos-14 ]]; then
-          # switch from LDC to freshly built DMD as host compiler
-          export HOST_DMD="$PWD/dmd/generated/osx/release/64/dmd"
-          export CXXFLAGS="-arch x86_64"
-          rm ./dmd/generated/osx/release/64/*.o
+          extraFlags=(HOST_DMD=ldmd2 DFLAGS="-mtriple=x86_64-apple-macos14" CXXFLAGS="-arch x86_64")
         fi
-        ./dmd/generated/build cxx-unittest
+        ./dmd/generated/build cxx-unittest "${extraFlags[@]}"

.gitignore

@@ -62,3 +62,5 @@ untracked_files/
 # Just in case
 /dmd
 .DS_Store
+/compiler/src/vcbuild/*.filters
+/compiler/src/vcbuild/*.sources

.pre-commit-config.yaml

@@ -1,6 +1,6 @@
 repos:
 - repo: https://github.com/pre-commit/pre-commit-hooks
-  rev: v4.4.0
+  rev: v6.0.0
   hooks:
   - id: trailing-whitespace
     exclude: >
@@ -22,6 +22,6 @@ repos:
   - id: no-commit-to-branch
     args: [--branch, master]
 - repo: https://github.com/sirosen/check-jsonschema
-  rev: 0.23.0
+  rev: 0.34.1
   hooks:
     - id: check-github-workflows

Makefile

@@ -16,6 +16,7 @@
 #     make -j$(nproc) dmd-test
 #
 # See compiler/src/build.d for variables affecting the compiler build.
+# Use HOST_DFLAGS (not DFLAGS) for extra flags (for the host compiler) to be used for the compiler build.
 
 include compiler/src/osmodel.mak
 
@@ -48,8 +49,15 @@ GENERATED:=generated
 BUILD_EXE:=$(GENERATED)/build$(EXE)
 RUN_EXE:=$(GENERATED)/run$(EXE)
 
+# forward any HOST_DFLAGS as DFLAGS for the build tool
+ifeq (,$(HOST_DFLAGS))
+    BUILD_CMD:=$(BUILD_EXE)
+else
+    BUILD_CMD:=$(BUILD_EXE) DFLAGS='$(HOST_DFLAGS)'
+endif
+
 .PHONY: all clean test html install \
-        dmd dmd-test druntime druntime-test \
+        dmd dmd-unittest dmd-test druntime druntime-test \
         auto-tester-build auto-tester-test buildkite-test \
         toolchain-info check-clean-git style
 
@@ -70,7 +78,7 @@ auto-tester-test:
 buildkite-test: test
 
 toolchain-info: $(BUILD_EXE)
-	$(BUILD_EXE) $@
+	$(BUILD_CMD) $@
 
 clean:
 	rm -rf $(GENERATED)
@@ -79,10 +87,12 @@ clean:
 	$(QUIET)$(MAKE) -C druntime clean
 
 dmd: $(BUILD_EXE)
-	$(BUILD_EXE) $@
+	$(BUILD_CMD) $@
+
+dmd-unittest: $(BUILD_EXE)
+	$(BUILD_CMD) unittest
 
-dmd-test: dmd druntime $(BUILD_EXE) $(RUN_EXE)
-	$(BUILD_EXE) unittest
+dmd-test: dmd-unittest dmd druntime $(RUN_EXE)
 	$(RUN_EXE) --environment
 
 druntime: dmd
@@ -94,7 +104,7 @@ druntime-test: dmd
 test: dmd-test druntime-test
 
 html: $(BUILD_EXE)
-	$(BUILD_EXE) $@
+	$(BUILD_CMD) $@
 
 # Creates Exuberant Ctags tags file
 tags: Makefile $(ECTAGS_FILES)
@@ -106,8 +116,8 @@ install:
 	echo "Darwin_64_32_disabled"
 else
 install: $(BUILD_EXE)
-	$(BUILD_EXE) man
-	$(BUILD_EXE) install INSTALL_DIR='$(if $(findstring $(OS),windows),$(shell cygpath -w '$(INSTALL_DIR)'),$(INSTALL_DIR))'
+	$(BUILD_CMD) man
+	$(BUILD_CMD) install INSTALL_DIR='$(if $(findstring $(OS),windows),$(shell cygpath -w '$(INSTALL_DIR)'),$(INSTALL_DIR))'
 	mkdir -p '$(INSTALL_DIR)'/man
 	cp -r $(GENERATED)/docs/man/* '$(INSTALL_DIR)'/man/
 	$(QUIET)$(MAKE) -C druntime install INSTALL_DIR='$(INSTALL_DIR)'
@@ -124,7 +134,7 @@ check-clean-git:
 	fi
 
 style: $(BUILD_EXE)
-	$(BUILD_EXE) $@
+	$(BUILD_CMD) $@
 
 .DELETE_ON_ERROR: # GNU Make directive (delete output files on error)
 

changelog/dmd.bitfield-default-init.dd

@@ -0,0 +1,16 @@
+Support for default values in C-style bitfields
+
+D now supports specifying default values for C-style bitfields in structs and classes.
+This brings valid D code closer to behavior allowed in C++20 and allows for more concise initialization of bitfield members.
+
+Value range checking is performed at compile-time to ensure the default value fits within the specified number of bits.
+
+-------
+struct S
+{
+    int a : 4 = 2;   // OK
+    int b : 2 = 5;   // Error: bitfield initializer `5` does not fit in 2 bits
+    uint c : 1 = 1;  // OK
+    bool d : 1 = 1;  // OK
+}
+-------

changelog/dmd.exception-rewrite.dd

@@ -0,0 +1,30 @@
+Finally statements are no longer rewritten to a sequence if no Exception was thrown
+
+Finally statements have been allowed to rewrite to sequences when no Exception was throwable from within the try body.
+This has been shown to be problematic as cleanup when an Error is thrown does not occur.
+
+By default this has been reverted back to the pre-2018 behavior of not doing the rewrite.
+
+To change this use the new switch `-checkactionfinally=off` to reenable the previous behavior.
+
+This behavior can be observed by running the following code:
+
+```d
+import core.stdc.stdio;
+
+void main() {
+    try {
+        callMe();
+    } finally {
+        printf("exiting!\n");
+    }
+}
+
+void callMe() {
+    throw new Error("hi there :)");
+}
+```
+
+When the switch is set to `on`, "exiting!" will be printed.
+
+The `-betterC` switch is unaffected by this change.

changelog/dmd.fastdfa.dd

@@ -0,0 +1,31 @@
+New experimental Data Flow Analysis Engine for nullability and truthiness
+
+A new experimental Data Flow Analysis (DFA) has been implemented under the preview flag ``-preview=fastdfa``.
+The intent of the engine is to be both fast and free from false positives, if successful it may in the future be turned on by default.
+
+No attributes have been implemented to date, before they are considered the engine itself must be both usable with the right tradeoffs and have desirable features.
+This has some side effects, it prevent separate compilation, function pointers, and cyclic functions from being analysable.
+These limitations are not supposed to prevent a successful compilation when in use.
+
+The engine itself is variable centric with a strong focus on giving up on analysing a variable if things get too complex for it.
+This can result in messages that may not appear to make sense for where they are emitted, due to the way shortcutting of analysis works.
+As an example of loops:
+
+```d
+void loopy()
+{
+    int* ptr = new int;
+
+    foreach (i; 0 .. 2) // Error: Variable `ptr` was required to be non-null and has become null
+    {
+        int val = *ptr;
+        ptr = null;
+    }
+}
+```
+
+If the engine is successful, the reporting mechanism would be replaced with a tracing state pass.
+This would offer for a function line by line explanation of how and why the engine thought something was true.
+
+The engine has been tested on a 100k LOC defensively written codebase without any false positives.
+The performance is similar to DIP1000 and is not supposed to be noticeable.