fix(settings): degrade gracefully when the legal notice fetch fails

GET /settings/instance fetched the optional legal_notice_url from the
cloudery and propagated any error, turning the whole response into an
HTTP 500 whenever the cloudery was down or slow. Since the front-end
relies on this core route on nearly every page, it would then loop
retrying it.

The legal notice is a non-essential enrichment: log the error and omit
the field instead of failing the response, so the route keeps returning
the locally-available settings even when the cloudery is unreachable.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: Crash--

web/settings/instance.go

@@ -82,11 +82,10 @@ func (h *HTTPHandler) getInstance(c echo.Context) error {
 		return err
 	}
 
-	url, err := h.svc.GetLegalNoticeUrl(inst)
-	if err != nil {
-		return err
-	}
-	if url != "" {
+	if url, err := h.svc.GetLegalNoticeUrl(inst); err != nil {
+		inst.Logger().WithNamespace("settings").
+			Warnf("Failed to fetch the legal notice URL from the cloudery: %s", err)
+	} else if url != "" {
 		doc.M["legal_notice_url"] = url
 	}
 

web/settings/settings_test.go

@@ -637,6 +637,22 @@ func TestSettings(t *testing.T) {
 		attrs.HasValue("org_id", "test-org-id-456")
 	})
 
+	t.Run("GetInstanceDegradesWhenLegalNoticeFails", func(t *testing.T) {
+		e := testutils.CreateTestClient(t, tsURL)
+		svc.On("GetLegalNoticeUrl", testInstance).
+			Return("", fmt.Errorf("cloudery is down")).Once()
+
+		obj := e.GET("/settings/instance").
+			WithCookie(sessCookie, "connected").
+			WithHeader("Authorization", "Bearer "+token).
+			Expect().Status(200).
+			JSON(httpexpect.ContentOpts{MediaType: "application/vnd.api+json"}).
+			Object()
+
+		attrs := obj.Value("data").Object().Value("attributes").Object()
+		attrs.NotContainsKey("legal_notice_url")
+	})
+
 	t.Run("UpdateInstance", func(t *testing.T) {
 		e := testutils.CreateTestClient(t, tsURL)