Skip to content

Update documentations and notebooks with reduce_dimensions#962

Merged
Graciaaa3 merged 8 commits into
mainfrom
update-umap-docs
Jun 26, 2026
Merged

Update documentations and notebooks with reduce_dimensions#962
Graciaaa3 merged 8 commits into
mainfrom
update-umap-docs

Conversation

@Graciaaa3

Copy link
Copy Markdown
Collaborator

Change Description

Finishing PR #932 on updating the docs and notebooks that use umap to use reduce_dimensions.

@Graciaaa3 Graciaaa3 requested a review from drewoldag June 25, 2026 21:59
@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@Graciaaa3 Graciaaa3 self-assigned this Jun 25, 2026
@codecov

codecov Bot commented Jun 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.87%. Comparing base (cce48cd) to head (bb7c7e2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #962   +/-   ##
=======================================
  Coverage   64.87%   64.87%           
=======================================
  Files          82       82           
  Lines        7909     7909           
=======================================
  Hits         5131     5131           
  Misses       2778     2778           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Graciaaa3 Graciaaa3 removed the request for review from drewoldag June 25, 2026 22:23

@drewoldag drewoldag left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks for putting it together!

Comment thread pyproject.toml Outdated
Co-authored-by: Drew Oldag <47493171+drewoldag@users.noreply.github.com>
@Graciaaa3

Copy link
Copy Markdown
Collaborator Author

Actually, I noticed that the visualize verb is currently tied specifically to the umap verb. I tried simply changing it to reduce_dimensions, but that introduced some issues. I'm still looking into what's causing the problem.

@drewoldag drewoldag left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - one additional renaming suggestion.

Comment thread docs/common_workflows.rst Outdated

@drewoldag drewoldag left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, looks good.

@Graciaaa3 Graciaaa3 merged commit 0f9cee0 into main Jun 26, 2026
8 checks passed
@Graciaaa3 Graciaaa3 deleted the update-umap-docs branch June 26, 2026 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants