Add option to skip signature verification#821
Merged
habara-k merged 8 commits intoline:masterfrom Sep 18, 2025
Merged
Conversation
e9cc8d8 to
ddbbd44
Compare
Yang-33
reviewed
Jul 4, 2025
Contributor
Yang-33
left a comment
There was a problem hiding this comment.
can you address comments written in line/line-bot-sdk-go#595 (review) in this repository?
39d9b47 to
9f0b4f0
Compare
Yang-33
reviewed
Jul 8, 2025
README.rst
Outdated
| # or with skip_signature_verification | ||
| parser = linebot.v3.WebhookParser( | ||
| 'YOUR_CHANNEL_SECRET', | ||
| skip_signature_verification=lambda: True # or a function that returns a boolean |
Contributor
There was a problem hiding this comment.
line/line-bot-sdk-go#595 (comment)
Therefor I think False should be used in example.
Yang-33
reviewed
Jul 8, 2025
Contributor
There was a problem hiding this comment.
Yang-33
approved these changes
Sep 18, 2025
Contributor
|
please release after merging this change~ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Motivation
The signature returned with webhooks is calculated using a single channel secret. If the bot owner changes their channel secret, the signature for webhooks starts being calculated using the new channel secret. To avoid signature verification failures, the bot owner must update the channel secret on their server, which is used for signature verification. However, if there is a timing mismatch in the update—and such a mismatch is almost unavoidable—verification will fail during that period.
In such cases, having an option to skip signature verification for webhooks would be a convenient way to avoid these issues.
Related PRs