Closed
Conversation
habara-k
force-pushed
the
remove-deprecated-v2
branch
from
bc17d34 to
f3b6213
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove all deprecated v2 legacy modules (
linebot.api,linebot.models,linebot.webhook,linebot.http_client, etc.) that have been replaced bylinebot.v3in #985.After this change, only
linebot.v3remains as the public API surface.What's removed
linebot.api(LineBotApi),linebot.async_api(AsyncLineBotApi),linebot.webhook,linebot.exceptions,linebot.http_client,linebot.async_http_client,linebot.aiohttp_async_http_client,linebot.utils,linebot.deprecationslinebot.modelspackage (25 files) andlinebot.constantstests/api/,tests/async_api/,tests/models/, and legacy top-level test fileslinebot.rst,linebot.models.rstand their reference inindex.rstrequests,future,Deprecated(no longer used)CodegenCommandclass (generatedasync_api.pyfromapi.py)Other changes
linebot/v3/exceptions.py: the only remaining usage of thefuturepackage (a Python 2 compatibility library). Replacedfuture.utils.with_metaclasswith Python 3metaclass=syntax to fully remove thefuturedependency.