Add test to check content type header#464
Merged
Yang-33 merged 1 commit intoline:masterfrom Apr 4, 2025
Merged
Conversation
mokuzon
approved these changes
Apr 4, 2025
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds tests for the headers for scenario about downloading.
The behavior where all header names become lowercase when converting the response header object to a hash likely depends on
Net::HTTP.Some libraries including
Net::HTTPconvert uppercase access to lowercase(In ruby, String#downcase.to_s), but once it's converted to a hash in bot-sdk-ruby, they don't do this.However, since HTTP header names are not supposed to be case-sensitive (regardless of the programming language), I think this behavior is acceptable.