Skip to content

Add comments for clients#468

Merged
Yang-33 merged 4 commits intoline:masterfrom
Yang-33:comment-for-client
Apr 7, 2025
Merged

Add comments for clients#468
Yang-33 merged 4 commits intoline:masterfrom
Yang-33:comment-for-client

Conversation

@Yang-33
Copy link
Copy Markdown
Contributor

@Yang-33 Yang-33 commented Apr 4, 2025

This change adds comments for sdk users in code related to the client.

(1) The internal HTTP client is exposed, but this change adds caution against using it. If a breaking change is made to this, the version will be raised, ignoring semver.
(2) For the user-facing HTTP client, this change adds comments with examples using YARD.

Comments on the class methods will be improved in a separate PR.

@Yang-33 Yang-33 self-assigned this Apr 4, 2025
@Yang-33 Yang-33 force-pushed the comment-for-client branch from 583894b to c81b2a6 Compare April 4, 2025 17:33
@Yang-33 Yang-33 requested a review from a team April 7, 2025 01:05
@Yang-33 Yang-33 merged commit 0e395fb into line:master Apr 7, 2025
6 checks passed
@Yang-33 Yang-33 deleted the comment-for-client branch April 7, 2025 06:02
Copy link
Copy Markdown
Contributor

@mokuzon mokuzon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants