Use rbs collection for validation by rbs command #479
Merged
Conversation
Yang-33
force-pushed
the
steep-http-client
branch
from
637df9c to
c79c1b5
Compare
Yang-33
commented
Apr 8, 2025
| group :development, :test do | ||
| # ref: http://docs.rubocop.org/en/latest/installation/ | ||
| gem 'rack', '~> 3.0' | ||
| gem 'rbs', '~> 3.9.2' |
Contributor
Author
There was a problem hiding this comment.
if we don't write version explicitly, github actions runner uses 2.9.x and throws error.
Yang-33
commented
Apr 8, 2025
Comment on lines
-40
to
-50
| rbs: | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| contents: read | ||
| steps: | ||
| - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | ||
| - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1.229.0 | ||
| with: | ||
| ruby-version: '3.2' | ||
| - run: gem install rbs | ||
| - run: rbs -I sig validate |
Contributor
Author
There was a problem hiding this comment.
I'll remove rbs checks from here after this PR gets approve.
mokuzon
approved these changes
Apr 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the next PR, it will define the type for the HTTP client and make slight modifications to the code. In the process, types from other libraries will be needed. This change is a preparation for that. It imports the types of the necessary external libraries using the
rbs validatecommand.